Re: [PATCH AUTOSEL 5.4 211/350] rfkill: allocate static minor

Greg Kroah-Hartman
2019-12-11T07:51:10Z

On Tue, Dec 10, 2019 at 04:05:16PM -0500, Sasha Levin wrote:
> From: Marcel Holtmann <marcel@holtmann.org>
>
> [ Upstream commit 8670b2b8b029a6650d133486be9d2ace146fd29a ]
>
> udev has a feature of creating /dev/<node> device-nodes if it finds
> a devnode:<node> modalias. This allows for auto-loading of modules that
> provide the node. This requires to use a statically allocated minor
> number for misc character devices.
>
> However, rfkill uses dynamic minor numbers and prevents auto-loading
> of the module. So allocate the next static misc minor number and use
> it for rfkill.
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> Link: https://lore.kernel.org/r/20191024174042.19851-1-marcel@holtmann.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> include/linux/miscdevice.h | 1 +
> net/rfkill/core.c | 9 +++++++--
> 2 files changed, 8 insertions(+), 2 deletions(-)

I'll go queue this up for 5.4.y now, as that's the only place that
should need it.

thanks,

greg k-h