Re: [PATCH AUTOSEL 5.4 276/350] net: bcmgenet: Add RGMII_RXID support

Florian Fainelli
2019-12-10T21:49:43Z

On 12/10/19 1:06 PM, Sasha Levin wrote:
> From: Stefan Wahren <wahrenst@gmx.net>
>
> [ Upstream commit da38802211cc3fd294211a642932edb09e3af632 ]
>
> This adds the missing support for the PHY mode RGMII_RXID.
> It's necessary for the Raspberry Pi 4.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

There are more changes required to make the GENET controller on the Pi 4
to work, how and why this was selected? Same comment applies to the 4.19
automatic selection.
--
Florian