Re: [PATCH AUTOSEL 5.4 148/350] media: ad5820: Define entity function

Pavel Machek
2019-12-12T13:48:23Z

> On Thu, Dec 12, 2019 at 01:19:38PM +0100, Pavel Machek wrote:
> > On Tue 2019-12-10 16:04:13, Sasha Levin wrote:
> > > From: Ricardo Ribalda Delgado <ribalda@kernel.org>
> > >
> > > [ Upstream commit 801ef7c4919efba6b96b5aed1e72844ca69e26d3 ]
> > >
> > > Without this patch, media_device_register_entity throws a warning:
> > >
> > > dev_warn(mdev->dev,
> > > "Entity type for entity %s was not initialized!\n",
> > > entity->name);
> >
> > This fixes warning, not a serious bug. Thus it is against stable
> > rules.
>
> That's a good enough fix for a real issue. We take patches in stable
> for this all the time.

I know you do this all the time...

But that's not what the documentation says you should be doing!

- It must fix a problem that causes a build error (but not for things
marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
security issue, or some "oh, that's not good" issue. In short,
something
critical.

I'd prefer you to act as the documentation says you would, but even
just fixing the documentation would be improvement over current
situation.

Thanks,
Pavel