From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: sthella@codeaurora.org
Cc: srinivas.kandagatla@linaro.org, agross@kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] nvmem: add QTI SDAM driver
Date: Thu, 19 Dec 2019 16:29:29 -0800 [thread overview]
Message-ID: <20191220002929.GJ448416@yoga> (raw)
In-Reply-To: <17c718c483db710b32b2dbbcf4637783@codeaurora.org>
On Thu 19 Dec 02:29 PST 2019, sthella@codeaurora.org wrote:
> On 2019-12-18 11:44, Bjorn Andersson wrote:
> > On Tue 17 Dec 01:20 PST 2019, Shyam Kumar Thella wrote:
[..]
> > > +subsys_initcall(sdam_init);
> >
> > module_platform_driver(sdam_driver), unless you have some strong
> > arguments for why this needs to be subsys_initcall
> There are some critical sybsystems which depend on nvmem data. So I would
> prefer using subsys_initcall().
How critical? Needed to kernel module loading?
Can you please document this need somehow? (either a comment here or
something in the commit message). Be specific.
THanks,
Bjorn
next prev parent reply other threads:[~2019-12-20 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 9:20 [PATCH] nvmem: add QTI SDAM driver Shyam Kumar Thella
2019-12-18 6:14 ` Bjorn Andersson
2019-12-19 10:29 ` sthella
2019-12-20 0:29 ` Bjorn Andersson [this message]
2019-12-23 10:51 ` sthella
2019-12-19 10:38 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220002929.GJ448416@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=sthella@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox