From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Can Guo <cang@codeaurora.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout
Date: Fri, 20 Dec 2019 09:51:23 +0530 [thread overview]
Message-ID: <20191220042123.GC2536@vkoul-mobl> (raw)
In-Reply-To: <20191220020835.GK448416@yoga>
On 19-12-19, 18:08, Bjorn Andersson wrote:
> On Thu 19 Dec 07:04 PST 2019, Vinod Koul wrote:
>
> > If we do full reset of the phy, it seems to take a couple of ms to come
> > up on my system so increase the timeout to 10ms.
> >
> > This was found by full reset addition by commit 870b1279c7a0
> > ("scsi: ufs-qcom: Add reset control support for host controller") and
> > fixes the regression to platforms by this commit.
> >
> > Suggested-by: Can Guo <cang@codeaurora.org>
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> This does look familiar...
>
> https://lore.kernel.org/linux-arm-msm/20191107000917.1092409-3-bjorn.andersson@linaro.org/
>
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> > index 091e20303a14..c2e800a3825a 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> > @@ -66,7 +66,7 @@
> > /* QPHY_V3_PCS_MISC_CLAMP_ENABLE register bits */
> > #define CLAMP_EN BIT(0) /* enables i/o clamp_n */
> >
> > -#define PHY_INIT_COMPLETE_TIMEOUT 1000
> > +#define PHY_INIT_COMPLETE_TIMEOUT 100000
>
> 100ms seems a little bit excessive, and we do end up waiting this long
> when we have PCIe links without an attached device...
>
> Do you need >10ms or could we just have my patch merged?
Yeah I quick tested 10ms as well and seems good for me, so either ways
if fine, but lets get it applied quickly :-)
--
~Vinod
next prev parent reply other threads:[~2019-12-20 4:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 15:04 [PATCH 0/4] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
2019-12-19 15:04 ` [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout Vinod Koul
2019-12-19 15:29 ` Jeffrey Hugo
2019-12-19 15:40 ` Vinod Koul
2019-12-20 2:08 ` Bjorn Andersson
2019-12-20 4:21 ` Vinod Koul [this message]
2019-12-19 15:04 ` [PATCH 2/4] phy: qcom-qmp: Use register defines Vinod Koul
2019-12-19 15:30 ` Jeffrey Hugo
2019-12-20 0:44 ` cang
2019-12-20 4:22 ` Vinod Koul
2019-12-19 15:04 ` [PATCH 3/4] phy: qcom-qmp: Add optional SW reset Vinod Koul
2019-12-19 15:31 ` Jeffrey Hugo
2019-12-20 0:22 ` cang
2019-12-20 0:49 ` cang
2019-12-20 4:24 ` Vinod Koul
2019-12-20 6:00 ` Can Guo
2019-12-20 7:10 ` Vinod Koul
2019-12-20 7:41 ` Can Guo
2019-12-20 7:53 ` Vinod Koul
2019-12-23 9:00 ` Manu Gautam
2019-12-23 9:02 ` Manu Gautam
2019-12-19 15:04 ` [PATCH 4/4] phy: qcom-qmp: remove duplicate powerdown write Vinod Koul
2019-12-19 15:31 ` Jeffrey Hugo
2019-12-20 1:30 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220042123.GC2536@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox