The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Huang Shijie <sjhuang@iluvatar.ai>
To: Jason Baron <jbaron@akamai.com>
Cc: <linux-kernel@vger.kernel.org>, <1537577747@qq.com>,
	Joe Perches <joe@perches.com>
Subject: Re: [PATCH v5] lib/dynamic_debug: make better dynamic log output
Date: Fri, 20 Dec 2019 13:45:49 +0800	[thread overview]
Message-ID: <20191220054548.GA18312@hsj-OptiPlex-5060> (raw)
In-Reply-To: <ec04aa8b-5c2a-28be-a32b-6d85a17d2f21@akamai.com>

On Thu, Dec 19, 2019 at 05:10:49PM -0500, Jason Baron wrote:
> 
> 
> On 12/19/19 2:47 AM, Huang Shijie wrote:
> > The driver strings, device name and net device name are not changed for
> > the driver's dynamic log output. But the dynamic_emit_prefix() which contains
> > the function names may change when the function names are changed.
> > 
> > So the patch makes the better dynamic log output.
> 
> Another point here is that currently the output precisely matches the
> non-dynamic debug counterpart strings if not prefix is emitted. So that
> changes with this patch. I think its nice to say that the output is the
> same as the non dynamic debug output except it may have an optional
> prefix....
okay. I will add it in the next version.

Thanks
Huang Shijie

  reply	other threads:[~2019-12-20  5:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09  9:44 [PATCH] lib/dynamic_debug: make better dynamic log output Huang Shijie
2019-12-10  6:38 ` [PATCH V2] " Huang Shijie
2019-12-10 18:16   ` Jason Baron
2019-12-11  1:50     ` Huang Shijie
2019-12-11  3:17 ` [PATCH v3] " Huang Shijie
2019-12-12  6:35 ` [PATCH v4] " Huang Shijie
2019-12-19  7:47 ` [PATCH v5] " Huang Shijie
2019-12-19 22:10   ` Jason Baron
2019-12-20  5:45     ` Huang Shijie [this message]
2019-12-20  6:02 ` [PATCH v6] " Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191220054548.GA18312@hsj-OptiPlex-5060 \
    --to=sjhuang@iluvatar.ai \
    --cc=1537577747@qq.com \
    --cc=jbaron@akamai.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox