public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port
@ 2019-12-20 10:05 Kishon Vijay Abraham I
  2019-12-20 10:06 ` Gustavo Pimentel
  2020-05-22 11:29 ` Lorenzo Pieralisi
  0 siblings, 2 replies; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2019-12-20 10:05 UTC (permalink / raw)
  To: Jingoo Han, Gustavo Pimentel, Lorenzo Pieralisi, Andrew Murray,
	Bjorn Helgaas
  Cc: linux-pci, linux-kernel

No functional change. Get "struct pcie_port *" from private data
pointer of "struct irq_domain" in dw_pcie_irq_domain_free() to make
it look similar to how "struct pcie_port *" is obtained in
dw_pcie_irq_domain_alloc()

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 395feb8ca051..c3d72b06e964 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -236,7 +236,7 @@ static void dw_pcie_irq_domain_free(struct irq_domain *domain,
 				    unsigned int virq, unsigned int nr_irqs)
 {
 	struct irq_data *d = irq_domain_get_irq_data(domain, virq);
-	struct pcie_port *pp = irq_data_get_irq_chip_data(d);
+	struct pcie_port *pp = domain->host_data;
 	unsigned long flags;
 
 	raw_spin_lock_irqsave(&pp->lock, flags);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port
  2019-12-20 10:05 [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port Kishon Vijay Abraham I
@ 2019-12-20 10:06 ` Gustavo Pimentel
  2020-05-22 11:29 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Pimentel @ 2019-12-20 10:06 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Jingoo Han, Lorenzo Pieralisi,
	Andrew Murray, Bjorn Helgaas
  Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org

On Fri, Dec 20, 2019 at 10:5:50, Kishon Vijay Abraham I <kishon@ti.com> 
wrote:

> No functional change. Get "struct pcie_port *" from private data
> pointer of "struct irq_domain" in dw_pcie_irq_domain_free() to make
> it look similar to how "struct pcie_port *" is obtained in
> dw_pcie_irq_domain_alloc()
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 395feb8ca051..c3d72b06e964 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -236,7 +236,7 @@ static void dw_pcie_irq_domain_free(struct irq_domain *domain,
>  				    unsigned int virq, unsigned int nr_irqs)
>  {
>  	struct irq_data *d = irq_domain_get_irq_data(domain, virq);
> -	struct pcie_port *pp = irq_data_get_irq_chip_data(d);
> +	struct pcie_port *pp = domain->host_data;
>  	unsigned long flags;
>  
>  	raw_spin_lock_irqsave(&pp->lock, flags);
> -- 
> 2.17.1


Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port
  2019-12-20 10:05 [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port Kishon Vijay Abraham I
  2019-12-20 10:06 ` Gustavo Pimentel
@ 2020-05-22 11:29 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2020-05-22 11:29 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Jingoo Han, Gustavo Pimentel, Andrew Murray, Bjorn Helgaas,
	linux-pci, linux-kernel

On Fri, Dec 20, 2019 at 03:35:50PM +0530, Kishon Vijay Abraham I wrote:
> No functional change. Get "struct pcie_port *" from private data
> pointer of "struct irq_domain" in dw_pcie_irq_domain_free() to make
> it look similar to how "struct pcie_port *" is obtained in
> dw_pcie_irq_domain_alloc()
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied (eventually) to pci/dwc, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index 395feb8ca051..c3d72b06e964 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -236,7 +236,7 @@ static void dw_pcie_irq_domain_free(struct irq_domain *domain,
>  				    unsigned int virq, unsigned int nr_irqs)
>  {
>  	struct irq_data *d = irq_domain_get_irq_data(domain, virq);
> -	struct pcie_port *pp = irq_data_get_irq_chip_data(d);
> +	struct pcie_port *pp = domain->host_data;
>  	unsigned long flags;
>  
>  	raw_spin_lock_irqsave(&pp->lock, flags);
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-22 11:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-20 10:05 [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port Kishon Vijay Abraham I
2019-12-20 10:06 ` Gustavo Pimentel
2020-05-22 11:29 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox