From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v6 1/4] perf report: Fix incorrectly added dimensions as switch perf data file
Date: Fri, 20 Dec 2019 14:53:58 +0100 [thread overview]
Message-ID: <20191220135358.GE17348@krava> (raw)
In-Reply-To: <20191220013722.20592-1-yao.jin@linux.intel.com>
On Fri, Dec 20, 2019 at 09:37:19AM +0800, Jin Yao wrote:
> We observed an issue that was some extra columns displayed after switching
> perf data file in browser. The steps to reproduce:
>
> 1. perf record -a -e cycles,instructions -- sleep 3
> 2. perf report --group
> 3. In browser, we use hotkey 's' to switch to another perf.data
> 4. Now in browser, the extra columns 'Self' and 'Children' are displayed.
>
> The issue is setup_sorting() executed again after repeat path, so dimensions
> are added again.
>
> This patch checks the last key returned from __cmd_report(). If it's
> K_SWITCH_INPUT_DATA, skips the setup_sorting().
>
> v6:
> ---
> No change.
>
> v5:
> ---
> New patch in v5.
>
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
for all 4 patches:
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
next prev parent reply other threads:[~2019-12-20 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 1:37 [PATCH v6 1/4] perf report: Fix incorrectly added dimensions as switch perf data file Jin Yao
2019-12-20 1:37 ` [PATCH v6 2/4] perf report: Change sort order by a specified event in group Jin Yao
2020-01-20 15:11 ` Jin, Yao
2019-12-20 1:37 ` [PATCH v6 3/4] perf report: Support a new key to reload the browser Jin Yao
2019-12-20 1:37 ` [PATCH v6 4/4] perf report: support hotkey to let user select any event for sorting Jin Yao
2019-12-20 13:53 ` Jiri Olsa [this message]
2019-12-20 16:34 ` [PATCH v6 1/4] perf report: Fix incorrectly added dimensions as switch perf data file Arnaldo Carvalho de Melo
2019-12-23 0:55 ` Jin, Yao
2019-12-23 13:02 ` Arnaldo Carvalho de Melo
2019-12-23 21:35 ` [tip: perf/urgent] " tip-bot2 for Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220135358.GE17348@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).