From: Oleg Nesterov <oleg@redhat.com>
To: qiwuchen55@gmail.com
Cc: christian.brauner@ubuntu.com, peterz@infradead.org,
mingo@kernel.org, prsood@codeaurora.org, kernel-team@android.com,
linux-kernel@vger.kernel.org, chenqiwu@xiaomi.com
Subject: Re: [PATCH v3] kernel/exit: do panic earlier to get coredump if global init task exit
Date: Fri, 20 Dec 2019 20:38:00 +0100 [thread overview]
Message-ID: <20191220193758.GE13464@redhat.com> (raw)
In-Reply-To: <1576736993-10121-1-git-send-email-qiwuchen55@gmail.com>
On 12/19, qiwuchen55@gmail.com wrote:
>
> @@ -517,10 +517,6 @@ static struct task_struct *find_child_reaper(struct task_struct *father,
> }
>
> write_unlock_irq(&tasklist_lock);
> - if (unlikely(pid_ns == &init_pid_ns)) {
> - panic("Attempted to kill init! exitcode=0x%08x\n",
> - father->signal->group_exit_code ?: father->exit_code);
> - }
>
> list_for_each_entry_safe(p, n, dead, ptrace_entry) {
> list_del_init(&p->ptrace_entry);
> @@ -766,6 +762,15 @@ void __noreturn do_exit(long code)
> acct_update_integrals(tsk);
> group_dead = atomic_dec_and_test(&tsk->signal->live);
> if (group_dead) {
> + /*
> + * If the last thread of global init exit, do panic
> + * immeddiately to get the coredump to find any clue
> + * for init task in userspace.
> + */
> + if (unlikely(is_global_init(tsk)))
> + panic("Attempted to kill init! exitcode=0x%08x\n",
> + tsk->signal->group_exit_code ?: (int)code);
> +
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2019-12-20 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 6:29 [PATCH v3] kernel/exit: do panic earlier to get coredump if global init task exit qiwuchen55
2019-12-19 10:42 ` Christian Brauner
2019-12-20 19:38 ` Oleg Nesterov [this message]
2019-12-20 19:52 ` Christian Brauner
2019-12-22 16:56 ` Applied patch "exit: panic before exit_mm() on global init exit" Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220193758.GE13464@redhat.com \
--to=oleg@redhat.com \
--cc=chenqiwu@xiaomi.com \
--cc=christian.brauner@ubuntu.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=prsood@codeaurora.org \
--cc=qiwuchen55@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox