From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
bpf <bpf@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libbpf: Fix build on read-only filesystems
Date: Fri, 20 Dec 2019 18:53:28 -0300 [thread overview]
Message-ID: <20191220215328.GB9076@kernel.org> (raw)
In-Reply-To: <CAEf4BzZW+bDxkdmXBJrrCHqBP5UT1NLJJ7mXLNqc6eypRCib6Q@mail.gmail.com>
Em Fri, Dec 20, 2019 at 01:45:52PM -0800, Andrii Nakryiko escreveu:
> On Fri, Dec 20, 2019 at 12:47 PM Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote:
> > Em Fri, Dec 20, 2019 at 12:29:36PM -0800, Andrii Nakryiko escreveu:
> > > On Thu, Dec 19, 2019 at 7:26 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > > > I got the following error when I tried to build perf on a read-only
> > > > filesystem with O=dir option.
> > > > $ cd /some/where/ro/linux/tools/perf
> > > > $ make O=$HOME/build/perf
> > > > ...
> > > > CC /home/namhyung/build/perf/lib.o
> > > > /bin/sh: bpf_helper_defs.h: Read-only file system
> > > > make[3]: *** [Makefile:184: bpf_helper_defs.h] Error 1
> > > > make[2]: *** [Makefile.perf:778: /home/namhyung/build/perf/libbpf.a] Error 2
> > > > make[2]: *** Waiting for unfinished jobs....
> > > > LD /home/namhyung/build/perf/libperf-in.o
> > > > AR /home/namhyung/build/perf/libperf.a
> > > > PERF_VERSION = 5.4.0
> > > > make[1]: *** [Makefile.perf:225: sub-make] Error 2
> > > > make: *** [Makefile:70: all] Error 2
> > > > It was becaused bpf_helper_defs.h was generated in current directory.
> > > > Move it to OUTPUT directory.
> > > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > > > ---
> > > Overall nothing is obviously broken, except you need to fix up
> > > selftests/bpf's Makefile as well.
> > > BTW, this patch doesn't apply cleanly to latest bpf-next, so please rebase.
> > > Also subject prefix should look like [PATCH bpf-next] if it's meant to
> > > be applied against bpf-next.
> > Shouldn't this be applied to the current merge window since a behaviour
> > that people relied, i.e. using O= to generate the build in a separate
> > directory, since its not possible to use the source dir tree as it is
> > read-only is now broken, i.e. isn't this a regression?
> Sure, it can be applied against bpf as well, but selftests still need
> to be fixed first.
I guess this can be done on a separate patch? I.e. if the user doesn't
use selftests the only regression it will see is when trying to build
tools/perf using O=.
I think two patches is best, better granularity, do you see a strict
need for both to be in the same patch?
- Arnaldo
next prev parent reply other threads:[~2019-12-20 21:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 3:25 [PATCH] libbpf: Fix build on read-only filesystems Namhyung Kim
2019-12-20 20:29 ` Andrii Nakryiko
2019-12-20 20:47 ` Arnaldo Carvalho de Melo
2019-12-20 21:45 ` Andrii Nakryiko
2019-12-20 21:53 ` Arnaldo Carvalho de Melo [this message]
2019-12-20 22:00 ` Andrii Nakryiko
2019-12-20 22:05 ` Arnaldo Carvalho de Melo
2019-12-21 8:25 ` Namhyung Kim
2019-12-21 16:22 ` Alexei Starovoitov
2019-12-23 3:05 ` [PATCH bpf] " Namhyung Kim
2019-12-23 5:45 ` Andrii Nakryiko
2019-12-23 5:54 ` Andrii Nakryiko
2019-12-23 6:09 ` Namhyung Kim
2019-12-23 6:13 ` [PATCH bpf v3] " Namhyung Kim
2019-12-23 6:29 ` Andrii Nakryiko
2019-12-23 14:39 ` Daniel Borkmann
2019-12-20 22:01 ` [PATCH] " Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220215328.GB9076@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox