public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Tomasz Duszynski <tduszyns@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency
Date: Mon, 23 Dec 2019 16:40:32 +0000	[thread overview]
Message-ID: <20191223164032.78498e6b@archlinux> (raw)
In-Reply-To: <20191213213808.124603-1-tduszyns@gmail.com>

On Fri, 13 Dec 2019 22:38:08 +0100
Tomasz Duszynski <tduszyns@gmail.com> wrote:

> IIO triggered buffer depends on IIO buffer which is missing from Kconfig
> file. This should go unnoticed most of the time because there's a
> chance something else has already enabled buffers. In some rare cases
> though one might experience kbuild warnings about unmet direct
> dependencies and build failures due to missing symbols.
> 
> Fix this by selecting IIO_BUFFER explicitly.
> 
> Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
Applied to the fixes-togreg branch of iio.git. Marked for stable and
with the addition of a fixes tag.

Thanks,

Jonathan

> ---
>  drivers/iio/chemical/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index fa4586037bb8..0b91de4df8f4 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -65,6 +65,7 @@ config IAQCORE
>  config PMS7003
>  	tristate "Plantower PMS7003 particulate matter sensor"
>  	depends on SERIAL_DEV_BUS
> +	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say Y here to build support for the Plantower PMS7003 particulate


      reply	other threads:[~2019-12-23 16:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 21:38 [PATCH] iio: chemical: pms7003: fix unmet triggered buffer dependency Tomasz Duszynski
2019-12-23 16:40 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191223164032.78498e6b@archlinux \
    --to=jic23@jic23.retrosnub.co.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tduszyns@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox