Re: [PATCH v4 12/13] gpiolib: add new ioctl() for monitoring changes in line info

Bartosz Golaszewski
2020-01-08T16:55:52Z

śr., 8 sty 2020 o 13:46 Andy Shevchenko
<andriy.shevchenko@linux.intel.com> napisał(a):
>
> On Tue, Dec 24, 2019 at 01:07:08PM +0100, Bartosz Golaszewski wrote:
> ...
>
> > - } else if (cmd == GPIO_GET_LINEINFO_IOCTL) {
> > + } else if (cmd == GPIO_GET_LINEINFO_IOCTL ||
> > + cmd == GPIO_GET_LINEINFO_WATCH_IOCTL) {
>
> What about to split the functionality to something like lineinfo_get() and...
>
> > struct gpioline_info lineinfo;
>
> > - struct gpio_desc *desc;
>
> Hmm... Is it correct patch for this change?

Yes, because instead of declaring *desc in every branch, we declare it
once and use it twice.

>
> >
> > if (copy_from_user(&lineinfo, ip, sizeof(lineinfo)))
> > return -EFAULT;
> > @@ -1246,11 +1260,25 @@ static long gpio_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> >
> > if (copy_to_user(ip, &lineinfo, sizeof(lineinfo)))
> > return -EFAULT;
> > +
> > + if (cmd == GPIO_GET_LINEINFO_WATCH_IOCTL)
> > + set_bit(desc_to_gpio(desc), priv->watched_lines);
> > +
>
> ...simple use
>
> } else if (cmd == GPIO_GET_LINEINFO_IOCTL) {
> return lineinfo_get();
> } else if {cmd == GPIO_GET_LINEINFO_WATCH_IOCTL) {
> ret = lineinfo_get()
> set_bit();
> return ret;
> }
>
> ?

You still need to retrieve *desc outside of lineinfo_get(). I think
it's not worth the hassle.

Bart