From: Pavel Machek <pavel@ucw.cz>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] leds: lm3692x: Disable chip on brightness 0
Date: Thu, 26 Dec 2019 11:29:56 +0100 [thread overview]
Message-ID: <20191226102956.GH4033@amd> (raw)
In-Reply-To: <e1dc56c07235063a9c0afbfc8c227b92b39ec3d4.1577272495.git.agx@sigxcpu.org>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Wed 2019-12-25 12:16:39, Guido Günther wrote:
> Otherwise there's a noticeable glow even with brightness 0. Also
> turning off the regulator can save additional power.
Ok, this will make set brightness slower, but I guess it makes sense.
Can you try to toggling brightness quickly from userspace, maybe even
from two threads, to ensure nothing really goes wrong there?
Hmm. And if this is independend of the other series, tell me and I can
apply v2.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-12-26 10:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 11:16 [PATCH 0/3] leds: lm3692x: Disable chip on brightness 0 Guido Günther
2019-12-25 11:16 ` [PATCH 1/3] leds: lm3692x: Move lm3692x_init and rename to lm3692x_leds_enable Guido Günther
2019-12-26 10:15 ` Pavel Machek
2019-12-25 11:16 ` [PATCH 2/3] leds: lm3692x: Split out lm3692x_leds_disable Guido Günther
2019-12-26 10:16 ` Pavel Machek
2019-12-25 11:16 ` [PATCH 3/3] leds: lm3692x: Disable chip on brightness 0 Guido Günther
2019-12-26 10:29 ` Pavel Machek [this message]
2019-12-27 12:56 ` Guido Günther
2019-12-26 10:14 ` [PATCH 0/3] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226102956.GH4033@amd \
--to=pavel@ucw.cz \
--cc=agx@sigxcpu.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox