From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=rArk=2Q=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E43D6C2D0DB
	for <linux-kernel@archiver.kernel.org>; Thu, 26 Dec 2019 14:40:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id BB4E52075E
	for <linux-kernel@archiver.kernel.org>; Thu, 26 Dec 2019 14:40:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1577371214;
	bh=efzHL22HYUz5k2qQqJeuKntAGwLxVj4J6991uGsCWa0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=FEreKPJBgmrYZ1vFWCORxYHFnFYBBWvfeAgBld+eoGl5NncTVkJnzwMHZKGkYC/sp
	 yuQOUTbMJ1j/R3wnrlnW+PrC121YtsT0y/3h8JujoMD1LX5EE+AhgRy9FlDw3Ati3C
	 WKPl6z8L06p+EEpk22T88n/atnCftu85M1lP5b/w=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726796AbfLZOkN (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 26 Dec 2019 09:40:13 -0500
Received: from mail.kernel.org ([198.145.29.99]:40498 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726534AbfLZOkM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Dec 2019 09:40:12 -0500
Received: from localhost (unknown [193.47.165.251])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id BA329206CB;
        Thu, 26 Dec 2019 14:40:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1577371212;
        bh=efzHL22HYUz5k2qQqJeuKntAGwLxVj4J6991uGsCWa0=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=rhu1Xm7Qbnh3tsvHXsjFnBoL58hSlI3bI6l15ImeRcmEyfGYXoT7ijYxWUe07+D9e
         cQETXFj7xvA8aAtZ3YjZ42UEGKabsv0JtXhdG51bBwQIR3RiSM9+1hHNVg69ziQ6ft
         VcgavZDqLHw77ruj3OLTdRxbWtJ5hjTSXvpUsM0w=
Date:   Thu, 26 Dec 2019 16:40:09 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     xiyuyang19@fudan.edu.cn
Cc:     yuanxzhang@fudan.edu.cn, kjlu@umn.edu,
        Xin Tan <tanxin.ctf@gmail.com>,
        Faisal Latif <faisal.latif@intel.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] infiniband: i40iw: fix a potential NULL pointer
 dereference
Message-ID: <20191226144009.GE6285@unreal>
References: <1577366516-19556-1-git-send-email-xiyuyang19@fudan.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1577366516-19556-1-git-send-email-xiyuyang19@fudan.edu.cn>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 26, 2019 at 09:21:56PM +0800, xiyuyang19@fudan.edu.cn wrote:
> From: Xiyu Yang <xiyuyang19@fudan.edu.cn>
>
> in_dev_get may return a NULL object. The fix handles the situation
> by adding a check to avoid NULL pointer dereference on idev,
> as pick_local_ipaddrs does.
>
> Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
> ---
> Changes in v2:
> - Release rtnl lock when in_dev_get return NULL
> Changes in v3:
> - Continue the next loop when in_dev_get return NULL
>
>  drivers/infiniband/hw/i40iw/i40iw_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>