Re: [PATCH AUTOSEL 4.19 46/84] tcp/dccp: fix possible race __inet_lookup_established()

Naresh Kamboju
2020-01-02T08:01:37Z

On Fri, 27 Dec 2019 at 23:17, Sasha Levin <sashal@kernel.org> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> [ Upstream commit 8dbd76e79a16b45b2ccb01d2f2e08dbf64e71e40 ]
>
> Michal Kubecek and Firo Yang did a very nice analysis of crashes
> happening in __inet_lookup_established().
>
> Since a TCP socket can go from TCP_ESTABLISH to TCP_LISTEN
> (via a close()/socket()/listen() cycle) without a RCU grace period,
> I should not have changed listeners linkage in their hash table.
>
> They must use the nulls protocol (Documentation/RCU/rculist_nulls.txt),
> so that a lookup can detect a socket in a hash list was moved in
> another one.
>
> Since we added code in commit d296ba60d8e2 ("soreuseport: Resolve
> merge conflict for v4/v6 ordering fix"), we have to add
> hlist_nulls_add_tail_rcu() helper.

The kernel panic reported on all devices,
While running LTP syscalls accept* test cases on stable-rc-4.19 branch kernel.
This report log extracted from qemu_x86_64.

Reverting this patch re-solved kernel crash.

metadata:
git branch: linux-4.19.y
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git commit: 4e040169e8b7f4e1c50ceb0f6596015ecc67a052
git describe: v4.19.92-112-g4e040169e8b7
make_kernelversion: 4.19.93-rc1
kernel-config:
http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/intel-corei7-64/lkft/linux-stable-rc-4.19/396/config

Crash log,

BUG: unable to handle kernel paging request at 0000000040000001
[ 23.578222] PGD 138f25067 P4D 138f25067 PUD 0
er run is 0h 15m[ 23.578222] Oops: 0000 [#1] SMP NOPTI
[ 23.578222] CPU: 1 PID: 2216 Comm: accept02 Not tainted 4.19.93-rc1 #1
[ 23.578222] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 1.12.0-1 04/01/2014
[ 23.578222] RIP: 0010:__inet_lookup_listener+0x12d/0x300
00s
[ts t_buffe r 23.578222] Code: 18 48 85 db 0f 84 fe 00 00 00 48 83 eb
68 0f 84 f4 00 00 00 0f b7 75 d0 44 8b 55 10 45 89 f1 45 31 ff 31 c0
45 89 de 89 75 b0 <4c> 3b 63 30 75 43 66 44 3b 6b 0e 75 3c 0f b6 73 13
40 f6 c6 20 75
[ 23.578222] RSP: 0018:ffff9e0dbba83c38 EFLAGS: 00010206
[ 23.578222] RAX: ffff9e0db6ff8a80 RBX: 000000003fffffd1 RCX: 0000000000000000
[ 23.578222] RDX: 0000000000000006 RSI: 0000000000000000 RDI: 00000000ffffffff
[ 23.578222] RBP: ffff9e0dbba83c88 R08: 000000000100007f R09: 0000000000000000
[ 23.578222] R10: 000000000100007f R11: 0000000000000000 R12: ffffffffbeb2fe40
[ 23.578222] R13: 000000000000d59f R14: 0000000000000000 R15: 0000000000000006
[ 23.578222] FS: 00007fbb30e57700(0000) GS:ffff9e0dbba80000(0000)
knlGS:0000000000000000
[ 23.578222] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 23.578222] CR2: 0000000040000001 CR3: 000000013276c000 CR4: 00000000003406e0
[ 23.578222] Call Trace:
[ 23.578222] <IRQ>
[ 23.578222] tcp_v4_rcv+0x4fe/0xc80
[ 23.578222] ip_local_deliver_finish+0xaf/0x390
[ 23.578222] ip_local_deliver+0x1a1/0x200
[ 23.578222] ? ip_sublist_rcv+0x420/0x420
[ 23.578222] ip_rcv_finish+0x88/0xd0
s.c:55: INFO: Te[ 23.578222] ip_rcv+0x142/0x200
[ 23.578222] ? ip_rcv_finish_core.isra.18+0x4e0/0x4e0
st is[ us ing guar 23.578222] ? process_backlog+0x6d/0x230
[ 23.578222] __netif_receive_skb_one_core+0x57/0x80
ded [bu ffe rs
ac2c3.578222] __netif_receive_skb+0x18/0x60
[ 23.578222] process_backlog+0xd4/0x230
[ 23.578222] net_rx_action+0x13e/0x420
[ 23.578222] ? __do_softirq+0x9b/0x426
[ 23.578222] __do_softirq+0xc7/0x426
[ 23.578222] ? ip_finish_output2+0x255/0x660
[ 23.578222] do_softirq_own_stack+0x2a/0x40
[ 23.578222] </IRQ>
[ 23.578222] do_softirq.part.19+0x4d/0x60
[ 23.578222] __local_bh_enable_ip+0xd9/0xf0
[ 23.578222] ip_finish_output2+0x27e/0x660
[ 23.578222] ip_finish_output+0x235/0x370
[ 23.578222] ? ip_finish_output+0x235/0x370
[ 23.578222] ip_output+0x76/0x250
[ 23.578222] ? ip_fragment.constprop.50+0x80/0x80
[ 23.578222] ip_local_out+0x3f/0x70
[ 23.578222] __ip_queue_xmit+0x1ea/0x5f0
[ 23.578222] ? __lock_is_held+0x5a/0xa0
[ 23.578222] ip_queue_xmit+0x10/0x20
[ 23.578222] __tcp_transmit_skb+0x57c/0xb60
[ 23.578222] tcp_connect+0xccd/0x1030
[ 23.578222] tcp_v4_connect+0x515/0x550
[ 23.578222] __inet_stream_connect+0x249/0x390
[ 23.578222] ? __local_bh_enable_ip+0x7f/0xf0
[ 23.578222] inet_stream_connect+0x3b/0x60
[ 23.578222] __sys_connect+0xa3/0x120
[ 23.578222] ? kfree+0x203/0x240
[ 23.578222] ? syscall_trace_enter+0x1e3/0x350
[ 23.578222] ? trace_hardirqs_off_caller+0x22/0xf0
[ 23.578222] ? do_syscall_64+0x17/0x1a0
[ 23.578222] ? lockdep_hardirqs_on+0xef/0x180
[ 23.578222] ? do_syscall_64+0x17/0x1a0
[ 23.578222] __x64_sys_connect+0x1a/0x20
[ 23.578222] do_syscall_64+0x55/0x1a0
[ 23.578222] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[ 23.578222] RIP: 0033:0x7fbb31a1c927
[ 23.578222] Code: 44 00 00 41 54 41 89 d4 55 48 89 f5 53 89 fb 48
83 ec 10 e8 0b f9 ff ff 44 89 e2 48 89 ee 89 df 41 89 c0 b8 2a 00 00
00 0f 05 <48> 3d 00 f0 ff ff 77 33 44 89 c7 89 44 24 0c e8 45 f9 ff ff
8b 44
[ 23.578222] RSP: 002b:00007fbb30e56e00 EFLAGS: 00000293 ORIG_RAX:
000000000000002a
[ 23.578222] RAX: ffffffffffffffda RBX: 0000000000000008 RCX: 00007fbb31a1c927
[ 23.578222] RDX: 0000000000000010 RSI: 00007fbb31e4bff0 RDI: 0000000000000008
[ 23.578222] RBP: 00007fbb31e4bff0 R08: 0000000000000000 R09: 0000000000000010
[ 23.578222] R10: 000000000000010b R11: 0000000000000293 R12: 0000000000000010
[ 23.578222] R13: 0000000000412b64 R14: 0000000000000054 R15: 0000000000000000
[ 23.578222] Modules linked in: fuse
[ 23.578222] CR2: 0000000040000001
[ 23.578222] ---[ end trace f7e2316fdadfb18a ]---
[ 23.578222] RIP: 0010:__inet_lookup_listener+0x12d/0x300
[ 23.578222] Code: 18 48 85 db 0f 84 fe 00 00 00 48 83 eb 68 0f 84
f4 00 00 00 0f b7 75 d0 44 8b 55 10 45 89 f1 45 31 ff 31 c0 45 89 de
89 75 b0 <4c> 3b 63 30 75 43 66 44 3b 6b 0e 75 3c 0f b6 73 13 40 f6 c6
20 75
[ 23.578222] RSP: 0018:ffff9e0dbba83c38 EFLAGS: 00010206
[ 23.578222] RAX: ffff9e0db6ff8a80 RBX: 000000003fffffd1 RCX: 0000000000000000
[ 23.578222] RDX: 0000000000000006 RSI: 0000000000000000 RDI: 00000000ffffffff
[ 23.578222] RBP: ffff9e0dbba83c88 R08: 000000000100007f R09: 0000000000000000
[ 23.578222] R10: 000000000100007f R11: 0000000000000000 R12: ffffffffbeb2fe40
[ 23.578222] R13: 000000000000d59f R14: 0000000000000000 R15: 0000000000000006
[ 23.578222] FS: 00007fbb30e57700(0000) GS:ffff9e0dbba80000(0000)
knlGS:0000000000000000
[ 23.578222] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 23.578222] CR2: 0000000040000001 CR3: 000000013276c000 CR4: 00000000003406e0
[ 23.578222] Kernel panic - not syncing: Fatal exception in interrupt
ept02.c:127: INFO: Starting listener on port: 54687
[ 23.578222] Kernel Offset: 0x3c200000 from 0xffffffff81000000
(relocation range: 0xffffffff80000000-0xffffffffbfffffff)
[ 23.578222] ---[ end Kernel panic - not syncing: Fatal exception in
interrupt ]---