* [PATCH] siox: Use the correct style for SPDX License Identifier
@ 2019-12-28 7:15 Nishad Kamdar
2019-12-30 12:52 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: Nishad Kamdar @ 2019-12-28 7:15 UTC (permalink / raw)
To: Thorsten Scherer, Uwe Kleine-König, Pengutronix Kernel Team,
Greg Kroah-Hartman, Joe Perches
Cc: linux-kernel
This patch corrects the SPDX License Identifier style in
header file related to Ecklemann SIOX driver.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
drivers/siox/siox.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/siox/siox.h b/drivers/siox/siox.h
index c674bf6fb119..f08b43b713c5 100644
--- a/drivers/siox/siox.h
+++ b/drivers/siox/siox.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (C) 2015-2017 Pengutronix, Uwe Kleine-König <kernel@pengutronix.de>
*/
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] siox: Use the correct style for SPDX License Identifier
2019-12-28 7:15 [PATCH] siox: Use the correct style for SPDX License Identifier Nishad Kamdar
@ 2019-12-30 12:52 ` Uwe Kleine-König
2020-01-01 13:18 ` Nishad Kamdar
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2019-12-30 12:52 UTC (permalink / raw)
To: Nishad Kamdar
Cc: Thorsten Scherer, Pengutronix Kernel Team, Greg Kroah-Hartman,
Joe Perches, linux-kernel
On Sat, Dec 28, 2019 at 12:45:48PM +0530, Nishad Kamdar wrote:
> This patch corrects the SPDX License Identifier style in
> header file related to Ecklemann SIOX driver.
s/Ecklemann/Eckelmann/
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
Other than that, I assume this is fine. So if you fix the name above,
you can add my Acked-by:.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] siox: Use the correct style for SPDX License Identifier
2019-12-30 12:52 ` Uwe Kleine-König
@ 2020-01-01 13:18 ` Nishad Kamdar
0 siblings, 0 replies; 3+ messages in thread
From: Nishad Kamdar @ 2020-01-01 13:18 UTC (permalink / raw)
To: Uwe Kleine-König, Thorsten Scherer, Pengutronix Kernel Team,
Greg Kroah-Hartman, Joe Perches
Cc: linux-kernel
On Mon, Dec 30, 2019 at 01:52:32PM +0100, Uwe Kleine-König wrote:
> On Sat, Dec 28, 2019 at 12:45:48PM +0530, Nishad Kamdar wrote:
> > This patch corrects the SPDX License Identifier style in
> > header file related to Ecklemann SIOX driver.
>
> s/Ecklemann/Eckelmann/
>
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
>
> Other than that, I assume this is fine. So if you fix the name above,
> you can add my Acked-by:.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
Ok, I'll do that.
Thank you very much for the review.
Regards,
Nishad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-01 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-28 7:15 [PATCH] siox: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-12-30 12:52 ` Uwe Kleine-König
2020-01-01 13:18 ` Nishad Kamdar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox