public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Francois Saint-Jacques <fsaintjacques@gmail.com>
Cc: Steve.MacLean@microsoft.com, eranian@google.com,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH v3] perf inject --jit: Remove //anon mmap events
Date: Sun, 29 Dec 2019 16:51:12 +0100	[thread overview]
Message-ID: <20191229155112.GA21785@krava> (raw)
In-Reply-To: <CABNn7+pYPSfduacOATcKT1X_=qs70i7Bc8pELXDahY7BoB9_wQ@mail.gmail.com>

On Sat, Dec 28, 2019 at 01:02:13PM -0500, Francois Saint-Jacques wrote:
> I'd just like to weight in that this patch fixes the issue Steve
> mentioned. I have a local experiment using LLVM's ORC jit with jitdump
> support and couldn't get any symbols recognized by perf until applying
> this patch.

great, please reply to the orginal patch post with tested-by

Arnaldo, could you please check on this one?

there was some discussion about used clockid, but Stephane or
any other jit guys did not raise any particular concern AFAICS,
also it's simple enough to revert in case there's any issue

thanks,
jirka

> 
> Thank you,
> François
> 


  reply	other threads:[~2019-12-29 15:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-28 18:02 [PATCH v3] perf inject --jit: Remove //anon mmap events Francois Saint-Jacques
2019-12-29 15:51 ` Jiri Olsa [this message]
2020-04-27 22:03   ` [EXTERNAL] " Steve MacLean
2020-04-28  9:53     ` Jiri Olsa
  -- strict thread matches above, loose matches on Subject: below --
2019-10-31 20:30 Steve MacLean
2019-11-01  8:27 ` Jiri Olsa
2019-11-09 16:49   ` Steve MacLean
2019-11-11 11:33     ` Jiri Olsa
2019-11-11 21:35       ` Steve MacLean
2019-12-10 21:08         ` Steve MacLean
2019-12-11 12:44 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191229155112.GA21785@krava \
    --to=jolsa@redhat.com \
    --cc=Steve.MacLean@microsoft.com \
    --cc=acme@kernel.org \
    --cc=eranian@google.com \
    --cc=fsaintjacques@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox