Re: [PATCH 4.19 159/219] x86/crash: Add a forward declaration of struct kimage

Pavel Machek
2019-12-31T08:21:09Z

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Sun 2019-12-29 18:19:21, Greg Kroah-Hartman wrote:
> From: Lianbo Jiang <lijiang@redhat.com>
>
> [ Upstream commit 112eee5d06007dae561f14458bde7f2a4879ef4e ]
>
> Add a forward declaration of struct kimage to the crash.h header because
> future changes will invoke a crash-specific function from the realmode
> init path and the compiler will complain otherwise like this:
>
> In file included from arch/x86/realmode/init.c:11:
> ./arch/x86/include/asm/crash.h:5:32: warning: ‘struct kimage’ declared inside\

This is not needed in 4.19-stable, as
6f599d84231fd27e42f4ca2a786a6641e8cddf00 is not being backported
there. (But is simple enough not to do harm).

Best regards,
Pavel

> @@ -2,6 +2,8 @@
> #ifndef _ASM_X86_CRASH_H
> #define _ASM_X86_CRASH_H
>
> +struct kimage;
> +
> int crash_load_segments(struct kimage *image);
> int crash_copy_backup_region(struct kimage *image);
> int crash_setup_memmap_entries(struct kimage *image,

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]