* [PATCH] irqchip: define EXYNOS_IRQ_COMBINER
@ 2019-12-05 15:13 Hyunki Koo
2019-12-05 15:37 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Hyunki Koo @ 2019-12-05 15:13 UTC (permalink / raw)
To: tglx; +Cc: Hyunki Koo, Jason Cooper, Marc Zyngier, linux-kernel
From: Hyunki Koo <hyunki00.koo@samsung.com>
Not all exynos device have IRQ_COMBINER.
Thus add the config for EXYNOS_IRQ_COMBINER.
Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
---
drivers/irqchip/Kconfig | 7 +++++++
drivers/irqchip/Makefile | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index ba152954324b..1fff899a6421 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -393,6 +393,13 @@ config STM32_EXTI
select IRQ_DOMAIN
select GENERIC_IRQ_CHIP
+config EXYNOS_IRQ_COMBINER
+ bool "Samsung Exynos IRQ combiner support"
+ depends on ARCH_EXYNOS
+ help
+ Say yes here to add support for the IRQ combiner devices embedded
+ in Samsung Exynos chips.
+
config QCOM_IRQ_COMBINER
bool "QCOM IRQ combiner support"
depends on ARCH_QCOM && ACPI
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index e806dda690ea..60d7c7260fc3 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o
obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o
obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o
obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o
-obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o
+obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o
obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o
obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o
obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER
2019-12-05 15:13 [PATCH] irqchip: define EXYNOS_IRQ_COMBINER Hyunki Koo
@ 2019-12-05 15:37 ` Krzysztof Kozlowski
2019-12-05 15:44 ` Hyunki Koo
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-05 15:37 UTC (permalink / raw)
To: Hyunki Koo
Cc: tglx, Hyunki Koo, Jason Cooper, Marc Zyngier,
linux-kernel@vger.kernel.org
On Thu, 5 Dec 2019 at 16:16, Hyunki Koo <hyunki00.koo@gmail.com> wrote:
>
> From: Hyunki Koo <hyunki00.koo@samsung.com>
>
> Not all exynos device have IRQ_COMBINER.
> Thus add the config for EXYNOS_IRQ_COMBINER.
>
> Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> ---
> drivers/irqchip/Kconfig | 7 +++++++
> drivers/irqchip/Makefile | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
I do not have a clue what you want to achieve here. Where is the driver?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER
2019-12-05 15:37 ` Krzysztof Kozlowski
@ 2019-12-05 15:44 ` Hyunki Koo
2019-12-05 16:01 ` Marc Zyngier
0 siblings, 1 reply; 7+ messages in thread
From: Hyunki Koo @ 2019-12-05 15:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: tglx, Hyunki Koo, Jason Cooper, Marc Zyngier,
linux-kernel@vger.kernel.org
there is no new driver
I just want remove direct dependency between ARCH_EXYNOS and
exynos-combiner.c
because all exynos device is not needed the exynos-combiner
only used in aarch32 devices.
On 19. 12. 6. 오전 12:37, Krzysztof Kozlowski wrote:
> On Thu, 5 Dec 2019 at 16:16, Hyunki Koo <hyunki00.koo@gmail.com> wrote:
>> From: Hyunki Koo <hyunki00.koo@samsung.com>
>>
>> Not all exynos device have IRQ_COMBINER.
>> Thus add the config for EXYNOS_IRQ_COMBINER.
>>
>> Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
>> ---
>> drivers/irqchip/Kconfig | 7 +++++++
>> drivers/irqchip/Makefile | 2 +-
>> 2 files changed, 8 insertions(+), 1 deletion(-)
> I do not have a clue what you want to achieve here. Where is the driver?
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER
2019-12-05 15:44 ` Hyunki Koo
@ 2019-12-05 16:01 ` Marc Zyngier
0 siblings, 0 replies; 7+ messages in thread
From: Marc Zyngier @ 2019-12-05 16:01 UTC (permalink / raw)
To: Hyunki Koo
Cc: Krzysztof Kozlowski, tglx, Hyunki Koo, Jason Cooper, linux-kernel
On 2019-12-05 15:44, Hyunki Koo wrote:
> there is no new driver
>
> I just want remove direct dependency between ARCH_EXYNOS and
> exynos-combiner.c
>
> because all exynos device is not needed the exynos-combiner
>
> only used in aarch32 devices.
So breaking all existing configurations (that will rely on this
driver to be selected by ARCH_EXYNOS) is absolutely fine, as long
as your pet machine is not "polluted" by an unnecessary driver?
I'm sorry, but that's not acceptable.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] irqchip: define EXYNOS_IRQ_COMBINER
@ 2019-12-24 21:11 Hyunki Koo
2019-12-29 16:32 ` Krzysztof Kozlowski
2020-01-24 19:11 ` [tip: irq/core] irqchip: Define EXYNOS_IRQ_COMBINER tip-bot2 for Hyunki Koo
0 siblings, 2 replies; 7+ messages in thread
From: Hyunki Koo @ 2019-12-24 21:11 UTC (permalink / raw)
Cc: Hyunki Koo, Russell King, Kukjin Kim, Krzysztof Kozlowski,
Thomas Gleixner, Jason Cooper, Marc Zyngier, linux-arm-kernel,
linux-samsung-soc, linux-kernel
From: Hyunki Koo <hyunki00.koo@samsung.com>
This patch is written to clean up dependency of ARCH_EXYNOS
Not all exynos device have IRQ_COMBINER, especially aarch64 EXYNOS
but it is built for all exynos devices.
Thus add the config for EXYNOS_IRQ_COMBINER
remove direct dependency between ARCH_EXYNOS and exynos-combiner.c
and only selected on the aarch32 devices
Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
---
arch/arm/mach-exynos/Kconfig | 1 +
drivers/irqchip/Kconfig | 7 +++++++
drivers/irqchip/Makefile | 2 +-
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 4ef56571145b..6e7f10c8098a 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -12,6 +12,7 @@ menuconfig ARCH_EXYNOS
select ARCH_SUPPORTS_BIG_ENDIAN
select ARM_AMBA
select ARM_GIC
+ select EXYNOS_IRQ_COMBINER
select COMMON_CLK_SAMSUNG
select EXYNOS_ASV
select EXYNOS_CHIPID
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index ba152954324b..4c774d85375b 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -499,4 +499,11 @@ config SIFIVE_PLIC
If you don't know what to do here, say Y.
+config EXYNOS_IRQ_COMBINER
+ bool "Samsung Exynos IRQ combiner support" if COMPILE_TEST
+ depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST
+ help
+ Say yes here to add support for the IRQ combiner devices embedded
+ in Samsung Exynos chips.
+
endmenu
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index e806dda690ea..60d7c7260fc3 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o
obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o
obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o
obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o
-obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o
+obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o
obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o
obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o
obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] irqchip: define EXYNOS_IRQ_COMBINER
2019-12-24 21:11 [PATCH] irqchip: define EXYNOS_IRQ_COMBINER Hyunki Koo
@ 2019-12-29 16:32 ` Krzysztof Kozlowski
2020-01-24 19:11 ` [tip: irq/core] irqchip: Define EXYNOS_IRQ_COMBINER tip-bot2 for Hyunki Koo
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-29 16:32 UTC (permalink / raw)
To: Hyunki Koo
Cc: Hyunki Koo, Russell King, Kukjin Kim, Thomas Gleixner,
Jason Cooper, Marc Zyngier, linux-arm-kernel, linux-samsung-soc,
linux-kernel
On Wed, Dec 25, 2019 at 06:11:07AM +0900, Hyunki Koo wrote:
> From: Hyunki Koo <hyunki00.koo@samsung.com>
>
> This patch is written to clean up dependency of ARCH_EXYNOS
> Not all exynos device have IRQ_COMBINER, especially aarch64 EXYNOS
> but it is built for all exynos devices.
> Thus add the config for EXYNOS_IRQ_COMBINER
> remove direct dependency between ARCH_EXYNOS and exynos-combiner.c
> and only selected on the aarch32 devices
>
> Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> ---
> arch/arm/mach-exynos/Kconfig | 1 +
> drivers/irqchip/Kconfig | 7 +++++++
> drivers/irqchip/Makefile | 2 +-
> 3 files changed, 9 insertions(+), 1 deletion(-)
I assume it will go through irqchip tree:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
If not, let me know, so I could take it via samsung-soc.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip: irq/core] irqchip: Define EXYNOS_IRQ_COMBINER
2019-12-24 21:11 [PATCH] irqchip: define EXYNOS_IRQ_COMBINER Hyunki Koo
2019-12-29 16:32 ` Krzysztof Kozlowski
@ 2020-01-24 19:11 ` tip-bot2 for Hyunki Koo
1 sibling, 0 replies; 7+ messages in thread
From: tip-bot2 for Hyunki Koo @ 2020-01-24 19:11 UTC (permalink / raw)
To: linux-tip-commits
Cc: Hyunki Koo, Marc Zyngier, Krzysztof Kozlowski, x86, LKML
The following commit has been merged into the irq/core branch of tip:
Commit-ID: b74416dba33be3ed934e21df8286076cbd85b97f
Gitweb: https://git.kernel.org/tip/b74416dba33be3ed934e21df8286076cbd85b97f
Author: Hyunki Koo <hyunki00.koo@samsung.com>
AuthorDate: Wed, 25 Dec 2019 06:11:07 +09:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 20 Jan 2020 19:10:05
irqchip: Define EXYNOS_IRQ_COMBINER
This patch is written to clean up dependency of ARCH_EXYNOS
Not all exynos device have IRQ_COMBINER, especially aarch64 EXYNOS
but it is built for all exynos devices.
Thus add the config for EXYNOS_IRQ_COMBINER
remove direct dependency between ARCH_EXYNOS and exynos-combiner.c
and only selected on the aarch32 devices
Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20191224211108.7128-1-hyunki00.koo@gmail.com
---
arch/arm/mach-exynos/Kconfig | 1 +
drivers/irqchip/Kconfig | 7 +++++++
drivers/irqchip/Makefile | 2 +-
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 4ef5657..6e7f10c 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -12,6 +12,7 @@ menuconfig ARCH_EXYNOS
select ARCH_SUPPORTS_BIG_ENDIAN
select ARM_AMBA
select ARM_GIC
+ select EXYNOS_IRQ_COMBINER
select COMMON_CLK_SAMSUNG
select EXYNOS_ASV
select EXYNOS_CHIPID
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index bb89dfc..20c62d7 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -500,4 +500,11 @@ config SIFIVE_PLIC
If you don't know what to do here, say Y.
+config EXYNOS_IRQ_COMBINER
+ bool "Samsung Exynos IRQ combiner support" if COMPILE_TEST
+ depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST
+ help
+ Say yes here to add support for the IRQ combiner devices embedded
+ in Samsung Exynos chips.
+
endmenu
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 6c9262c..4b1c511 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o
obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o
obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o
obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o
-obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o
+obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o
obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o
obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o
obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-01-24 19:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-24 21:11 [PATCH] irqchip: define EXYNOS_IRQ_COMBINER Hyunki Koo
2019-12-29 16:32 ` Krzysztof Kozlowski
2020-01-24 19:11 ` [tip: irq/core] irqchip: Define EXYNOS_IRQ_COMBINER tip-bot2 for Hyunki Koo
-- strict thread matches above, loose matches on Subject: below --
2019-12-05 15:13 [PATCH] irqchip: define EXYNOS_IRQ_COMBINER Hyunki Koo
2019-12-05 15:37 ` Krzysztof Kozlowski
2019-12-05 15:44 ` Hyunki Koo
2019-12-05 16:01 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox