From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A91C2D0CE for ; Sun, 29 Dec 2019 17:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B33DA20718 for ; Sun, 29 Dec 2019 17:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641718; bh=abY7+N8N2VKwTKxhqMieCLr8hhyeXeu2UWpxBQVb9r8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Q7H+48JoKiMn6iAC2B892pJOCn3XmwzMDXtSqr0ip/5fMZbB+e1ggtFUDpnVrgjCa jrfmXTI5lou8INYWazSZwFGdPWoRSm0Xm6A7zrI1NwhmDB1IG6JEDZgNrN7HbByat5 EL+ro3sajFKtOXFE8LVy4KgNSxLD7+On/ancGDKE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731495AbfL2Rsh (ORCPT ); Sun, 29 Dec 2019 12:48:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:59946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731482AbfL2Rsd (ORCPT ); Sun, 29 Dec 2019 12:48:33 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F21D3206DB; Sun, 29 Dec 2019 17:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641713; bh=abY7+N8N2VKwTKxhqMieCLr8hhyeXeu2UWpxBQVb9r8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mEkCRSHQKOhyxFevY6UxQG2JIMu6a680SBxhFnTI49H4q5hPu9qEjzk/BjxEfSb0f 3h0o9Rx6PrrjNusW5qAN5NrZM3jJ9OZb55KDKI5VD06Y6MhlzXi5vW6+apRbbfOHey B+BM/Ol1Zr8V/oMlY2A/zrf4mkgESRM4sOd2KBvA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.4 179/434] media: st-mipid02: add a check for devm_gpiod_get_optional Date: Sun, 29 Dec 2019 18:23:52 +0100 Message-Id: <20191229172713.705108421@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit 61c03b631b74a38ab53753f3ee971a55886d4843 ] mipid02_probe misses a check for devm_gpiod_get_optional and may miss the failure. Add a check to fix the problem. Signed-off-by: Chuhong Yuan Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/st-mipid02.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c index 81285b8d5cfb..003ba22334cd 100644 --- a/drivers/media/i2c/st-mipid02.c +++ b/drivers/media/i2c/st-mipid02.c @@ -971,6 +971,11 @@ static int mipid02_probe(struct i2c_client *client) bridge->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(bridge->reset_gpio)) { + dev_err(dev, "failed to get reset GPIO\n"); + return PTR_ERR(bridge->reset_gpio); + } + ret = mipid02_get_regulators(bridge); if (ret) { dev_err(dev, "failed to get regulators %d", ret); -- 2.20.1