From: Faiz Abbas <faiz_abbas@ti.com>
To: <linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>
Cc: <ulf.hansson@linaro.org>, <adrian.hunter@intel.com>,
<faiz_abbas@ti.com>, <shawn.lin@rock-chips.com>
Subject: [PATCH 0/3] Fix issues with command queuing in arasan controllers
Date: Mon, 30 Dec 2019 14:53:40 +0530 [thread overview]
Message-ID: <20191230092343.30692-1-faiz_abbas@ti.com> (raw)
In some Arasan SDHCI controllers, after tuning, the tuning pattern data
is leftover in the sdhci buffer. This leads to issues with future data
commands, especially when command queuing is enabled. The following
patches help fix this issue by resetting data lines after tuning is
finished. The first two patches have been tested with TI's am65x and
j721e SoCs using the sdhci_am654 driver.
I have a strong suspicion that this is the same issue with
the sdhci-of-arasan driver where they are forced to dump data from the
buffer before enabling command queuing. I need help from someone with a
compatible platform to test this.
Faiz Abbas (3):
mmc: sdhci: Add Quirk to reset data lines after tuning
mmc: sdhci_am654: Enable Quirk to reset data after tuning
mmc: sdhci-of-arasan: Fix Command Queuing enable handling
drivers/mmc/host/sdhci-of-arasan.c | 21 ++++-----------------
drivers/mmc/host/sdhci.c | 3 +++
drivers/mmc/host/sdhci.h | 4 ++++
drivers/mmc/host/sdhci_am654.c | 9 ++++++---
4 files changed, 17 insertions(+), 20 deletions(-)
--
2.19.2
next reply other threads:[~2019-12-30 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 9:23 Faiz Abbas [this message]
2019-12-30 9:23 ` [PATCH 1/3] mmc: sdhci: Add Quirk to reset data lines after tuning Faiz Abbas
2019-12-30 9:23 ` [PATCH 2/3] mmc: sdhci_am654: Enable Quirk to reset data " Faiz Abbas
2019-12-30 9:23 ` [RFT PATCH 3/3] mmc: sdhci-of-arasan: Fix Command Queuing enable handling Faiz Abbas
2020-01-03 0:36 ` Shawn Lin
2020-01-08 11:30 ` [PATCH 0/3] Fix issues with command queuing in arasan controllers Faiz Abbas
2020-01-08 11:42 ` Adrian Hunter
2020-01-08 11:49 ` Faiz Abbas
2020-01-08 11:59 ` Adrian Hunter
2020-01-08 12:04 ` Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230092343.30692-1-faiz_abbas@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox