From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Hanzelik <mrhanzelik@gmail.com>
Cc: jerome.pouiller@silabs.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: wfx: Fix style issues with hif_rx.c
Date: Mon, 30 Dec 2019 12:39:15 +0100 [thread overview]
Message-ID: <20191230113915.GA890973@kroah.com> (raw)
In-Reply-To: <20191229223142.5pxmmu7sfwdtcn7d@mandalore.localdomain>
On Sun, Dec 29, 2019 at 05:31:42PM -0500, Matthew Hanzelik wrote:
> Fix the 80 line limit warning on line 79 of hif_rx.c.
>
> Also fixes the missing blank line warning on line 305 of hif_rx.c after
> the declaration of size_t len.
When ever you use the word "also" in a patch, that is a huge hint that
this needs to be broken up into more than one patch. Please do that
here, one patch per "thing" you are fixing.
Yes, for two tiny fixes like this it feels like overkill, but, if you
had done this, I would have been already able to take one of these
changes in my tree and you would have only had to redo the other by now
:)
thanks,
greg k-h
prev parent reply other threads:[~2019-12-30 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 22:31 [PATCH v3] Staging: wfx: Fix style issues with hif_rx.c Matthew Hanzelik
2019-12-29 22:51 ` Joe Perches
2019-12-30 11:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230113915.GA890973@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=jerome.pouiller@silabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrhanzelik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox