Re: [PATCH] mm/page_alloc: Skip non present sections on zone initialization

David Hildenbrand
2020-01-10T14:56:27Z

On 10.01.20 15:54, Kirill A. Shutemov wrote:
> On Fri, Jan 10, 2020 at 03:48:39PM +0100, David Hildenbrand wrote:
>>>> + if (!present_section_nr(section_nr))
>>>> + return section_nr_to_pfn(next_present_section_nr(section_nr));
>>>
>>> This won't compile. next_present_section_nr() is static to mm/sparse.c.
>>
>> We should then move that to the header IMHO.
>
> It looks like too much for a trivial cleanup.
>

Cleanup? This is a performance improvement ("fix the issue."). We should
avoid duplicating code where it can be avoided.

--
Thanks,

David / dhildenb