Re: [PATCH] mm/page_alloc: Skip non present sections on zone initialization

David Hildenbrand
2020-01-10T18:05:30Z

On 10.01.20 18:55, Kirill A. Shutemov wrote:
> On Fri, Jan 10, 2020 at 03:56:14PM +0100, David Hildenbrand wrote:
>> On 10.01.20 15:54, Kirill A. Shutemov wrote:
>>> On Fri, Jan 10, 2020 at 03:48:39PM +0100, David Hildenbrand wrote:
>>>>>> + if (!present_section_nr(section_nr))
>>>>>> + return section_nr_to_pfn(next_present_section_nr(section_nr));
>>>>>
>>>>> This won't compile. next_present_section_nr() is static to mm/sparse.c.
>>>>
>>>> We should then move that to the header IMHO.
>>>
>>> It looks like too much for a trivial cleanup.
>>>
>>
>> Cleanup? This is a performance improvement ("fix the issue."). We should
>> avoid duplicating code where it can be avoided.
>
> My original patch is in -mm tree and fixes the issue. The thread is about
> tiding it up.

Just send a v2? This thread is review of this patch.

If you don't want to clean it up, I can send patches ...

--
Thanks,

David / dhildenb