From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9448E35F606 for ; Sat, 28 Feb 2026 19:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772306558; cv=none; b=NNqTrqA88cVSPO/Raj6VSHhMU2b+u+ecX1+P1d0rco5ODVa+8gM+Wp0g9NeVuuuP6FD+eLmbcIX0FlV3J3Mb3MIKRY0x1zIs9bK1trnAsDpKH0mNdLXpdHjU7nBRRaRAe+vEvp4lGC3yJWX5NiwBxqVuxJQbYxCVo/p3aW/lxVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772306558; c=relaxed/simple; bh=Me8n7owqfLJkYyvUXHQx2u9wWsIV5A0WiPjr8BtB/4g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I55q7gJFfK5C/GjVr25GhOYVQcfl1GwySB00AcsRq/9LMrpLmPoOjKnIwgIo4QUHdNEfhCmLeLN1MBp5Zr6DSW6zWlqyU7bgmKTs6hmo6lUo63gt+Oxi8Db7hqsqsIbXFOd3fRQizh7Vao/Q/a/RBOokcyIvzkdwL+ARNi20gIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=y07saRYL; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="y07saRYL" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7d4c12ff3d5so3420644a34.2 for ; Sat, 28 Feb 2026 11:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772306554; x=1772911354; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jzurjNKz+LVtj7mOsHnigyTZSCq1BtpAu09PeT2WHx8=; b=y07saRYLoCC2ntjKJ4b9npncuFpyHNGurAj1W9UU09TwMAemNZ7YdHqasUjpbPHhoP Fo3TQCv8IK+dIhba2YaT6OHJsuv8emGbaKn4tbR/7Igqk4HAowbAi3l8jHfrBaGTwu2R OUN3fM8MXJ4NUfpzhIasd3aAsR5AO9H4KYl+ygBFYz6xH5mnhgIYl5GFxKUrGJTlbuYF LAWlOmSnzgDZGPaJzNC1RYOoG5FaBnX6R0+adFDmi6s336sHxwtI27kq1Hebwz/5EgC9 Z6ME29ppx85j1pOAdMC1Yy+PC83TPU2cJX65viqn4Urij04tDzURGJSdIijOnHThiZLd RUBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772306554; x=1772911354; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jzurjNKz+LVtj7mOsHnigyTZSCq1BtpAu09PeT2WHx8=; b=siQxCLbvV8pxxJd6dDPN0k3hMZXG+i04ab1PR5LRcDgb5a9RY9el/Ku5UWOm1su2nD nUKX1kXyd9TZiPB6W93NDDo8GclSIpmtZw/5LNGCd1VNoWqpd2LEby1M+4in6oGgGUwO 5Nxmv1KtDkr96GtvynyjiQSVty1tQ82ZrW8Wpw4KH5cIz+2OS4/t/iaBjzMh794oB9c/ HUP4rA8KkSZ7oqqJLDq86X+JOVVv6feYCJlY89o7NAkmILZKUU/vuHxDbZTrFT28f5yw OnM2EqtVOYUzqr8Vk42SrC9gZW9j0ZUGy4XzFvB1J6hq+R/wx1tc3TSymaec3S7+TC/i xayQ== X-Forwarded-Encrypted: i=1; AJvYcCVO0ZXFa4cZ0mcwnkOSChTJlhedoN8r8lkgjo+f62Y/HcjmzP8wSLeNlyc6oHI3rYGT0KN3jBTSuy80KVA=@vger.kernel.org X-Gm-Message-State: AOJu0YyYDBiTZDsOP7tDlQoZNpDo/+XK3NXEfqDhI5qS24qNk6Qacl/J H+o2ut5PaN2KqUc/fOxouvCKEx+sYnwl0yxjd6kxsSYWNc9lNOMmULqIH0cNN28PGns= X-Gm-Gg: ATEYQzzXZQoIIzVITpWe+QxJQEtEJmsFwSb5oTALEbyfdb6sOrY3mt0+rOKKYUQEEx2 zMSoxT2LDBtlYeFhA76QmEcoL2JkVFfAobLjlSUJa3p90fIEVKYoJiTWcfFU5u4i+39Wk9q3MqW YnV8fHFFuRqU7adRaJyGjF1IoTlcg/XHamZNhLpuf/d96O88TfYof23BBg2v0kEXxWAyWXqOGB4 Bm6wyjhqmr3tB43seQtQMoWqZH/4UuLuVz54b2ZPCQ7WFSaTxigvwo6NxxAe2245Amlo/EvuU4E axoQDcRS4ZHH1ZGdEeT5TT+U5cHtM65asDDnzTGH4gYMIvk9CFp3Hh2oCrFLPI2yzfP5nbzHNis 4LyVh+Te/IeSk03GgZkpWxi5sFdQFbbt2PypQQFhsLPQQMgJHXmW7H/Qumw/IvS+VyNz8+2vnRG qRziDbYOn3eAvZuAfDc0Rh7yTk9HSeM+kBlk7DxL+LFXbW6jFvxTqOW46MxcdpskzsIzhyUNHji A== X-Received: by 2002:a05:6870:e9aa:b0:40f:e6a:c0f7 with SMTP id 586e51a60fabf-41626e15081mr3595917fac.17.1772306554592; Sat, 28 Feb 2026 11:22:34 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:1031:c44e:9f1f:17c1? ([2600:8803:e7e4:500:1031:c44e:9f1f:17c1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4160d2cc08csm7236079fac.19.2026.02.28.11.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Feb 2026 11:22:34 -0800 (PST) Message-ID: <20195663-2091-41eb-b4b3-e8542d29ae32@baylibre.com> Date: Sat, 28 Feb 2026 13:22:32 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: st_sensors: fix trigger allocation To: Aleksandrs Vinarskis , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260228-st-iio-trigger-v1-1-abf5909e547f@vinarskis.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260228-st-iio-trigger-v1-1-abf5909e547f@vinarskis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/28/26 11:11 AM, Aleksandrs Vinarskis wrote: > Current hardcoded name prevents adding multiple st-sensors devices > on the same platform. Fix by aligning trigger name with other drivers. > > Signed-off-by: Aleksandrs Vinarskis > --- > Some platforms such as Dell XPS 9345 contains multiple accelerometers. > Fix st_sensors that currently only allows one device at the time. > --- > drivers/iio/common/st_sensors/st_sensors_trigger.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c > index 8a8ab688d7980f6dd43c660f90a0eba32c38388b..3b5615d1b6dd66ee0af6ccc83eb2fbd7b2c64d29 100644 > --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c > +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c > @@ -124,8 +124,9 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, > unsigned long irq_trig; > int err; > > - sdata->trig = devm_iio_trigger_alloc(parent, "%s-trigger", > - indio_dev->name); > + sdata->trig = devm_iio_trigger_alloc(parent, "%s-dev%d", > + indio_dev->name, > + iio_device_id(indio_dev)); Is this something that could potentially break userspace? Or are all of these just "always there" triggers that userspace doesn't have to touch? > if (sdata->trig == NULL) { > dev_err(parent, "failed to allocate iio trigger.\n"); > return -ENOMEM; > > --- > base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 > change-id: 20260228-st-iio-trigger-8ee1f219b566 > > Best regards,