From: Nishad Kamdar <nishadkamdar@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thorsten Scherer" <t.scherer@eckelmann.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] siox: Use the correct style for SPDX License Identifier
Date: Wed, 1 Jan 2020 18:48:19 +0530 [thread overview]
Message-ID: <20200101131817.GA2895@nishad> (raw)
In-Reply-To: <20191230125232.5ykjy3foljqjvhz4@pengutronix.de>
On Mon, Dec 30, 2019 at 01:52:32PM +0100, Uwe Kleine-König wrote:
> On Sat, Dec 28, 2019 at 12:45:48PM +0530, Nishad Kamdar wrote:
> > This patch corrects the SPDX License Identifier style in
> > header file related to Ecklemann SIOX driver.
>
> s/Ecklemann/Eckelmann/
>
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
>
> Other than that, I assume this is fine. So if you fix the name above,
> you can add my Acked-by:.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
Ok, I'll do that.
Thank you very much for the review.
Regards,
Nishad
prev parent reply other threads:[~2020-01-01 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 7:15 [PATCH] siox: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-12-30 12:52 ` Uwe Kleine-König
2020-01-01 13:18 ` Nishad Kamdar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200101131817.GA2895@nishad \
--to=nishadkamdar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=t.scherer@eckelmann.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox