From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
kernel-janitors@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/16] drm: bridge: dw-hdmi: constify copied structure
Date: Wed, 1 Jan 2020 16:52:42 +0200 [thread overview]
Message-ID: <20200101145242.GA4855@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1577864614-5543-16-git-send-email-Julia.Lawall@inria.fr>
Hi Julia,
Thank you for the patch.
On Wed, Jan 01, 2020 at 08:43:33AM +0100, Julia Lawall wrote:
> The dw_hdmi_hw structure is only copied into another structure,
> so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> index 2b7539701b42..dd56996fe9c7 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> @@ -291,7 +291,7 @@ static irqreturn_t snd_dw_hdmi_irq(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -static struct snd_pcm_hardware dw_hdmi_hw = {
> +static const struct snd_pcm_hardware dw_hdmi_hw = {
> .info = SNDRV_PCM_INFO_INTERLEAVED |
> SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_MMAP |
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-01-01 14:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 7:43 [PATCH 00/16] constify copied structure Julia Lawall
2020-01-01 7:43 ` [PATCH 01/16] ALSA: ad1816a: " Julia Lawall
2020-01-01 11:38 ` Takashi Iwai
2020-01-01 7:43 ` [PATCH 02/16] ALSA: " Julia Lawall
2020-01-01 11:39 ` Takashi Iwai
2020-01-01 7:43 ` [PATCH 03/16] [media] anysee: " Julia Lawall
2020-01-01 7:43 ` [PATCH 04/16] usb: gadget: udc: atmel: " Julia Lawall
2020-01-06 11:16 ` Cristian.Birsan
2020-01-01 7:43 ` [PATCH 05/16] media: isif: " Julia Lawall
2020-01-09 7:13 ` Lad, Prabhakar
2020-01-01 7:43 ` [PATCH 06/16] media: mt9v111: " Julia Lawall
2020-01-02 8:11 ` Jacopo Mondi
2020-01-01 7:43 ` [PATCH 07/16] video: sa1100fb: " Julia Lawall
2020-01-15 16:04 ` Bartlomiej Zolnierkiewicz
2020-01-01 7:43 ` [PATCH 08/16] pinctrl: ssbi-mpp: " Julia Lawall
2020-01-07 10:43 ` Linus Walleij
2020-01-01 7:43 ` [PATCH 09/16] powerpc/mpic: " Julia Lawall
2020-01-29 5:17 ` Michael Ellerman
2020-01-01 7:43 ` [PATCH 10/16] ASoC: qdsp6: q6asm-dai: " Julia Lawall
2020-01-01 21:41 ` Applied "ASoC: qdsp6: q6asm-dai: constify copied structure" to the asoc tree Mark Brown
2020-01-01 7:43 ` [PATCH 11/16] media: cx231xx: constify copied structure Julia Lawall
2020-01-01 7:43 ` [PATCH 12/16] SUNRPC: " Julia Lawall
2020-01-01 7:43 ` [PATCH 13/16] ptp: ptp_clockmatrix: " Julia Lawall
2020-01-01 15:43 ` Richard Cochran
2020-01-03 0:31 ` David Miller
2020-01-01 7:43 ` [PATCH 14/16] pinctrl: qcom: ssbi-gpio: " Julia Lawall
2020-01-07 10:44 ` Linus Walleij
2020-01-01 7:43 ` [PATCH 15/16] drm: bridge: dw-hdmi: " Julia Lawall
2020-01-01 14:52 ` Laurent Pinchart [this message]
2020-01-06 14:40 ` Neil Armstrong
2020-01-01 7:43 ` [PATCH 16/16] pinctrl: nuvoton: npcm7xx: " Julia Lawall
2020-01-07 10:45 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200101145242.GA4855@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Julia.Lawall@inria.fr \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox