From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F728C2D0DC for ; Thu, 2 Jan 2020 08:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62AB1215A4 for ; Thu, 2 Jan 2020 08:58:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WdYBfOGl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgABI6U (ORCPT ); Thu, 2 Jan 2020 03:58:20 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50661 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727890AbgABI6T (ORCPT ); Thu, 2 Jan 2020 03:58:19 -0500 Received: by mail-wm1-f66.google.com with SMTP id a5so4982526wmb.0 for ; Thu, 02 Jan 2020 00:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rF2GOyv1qKGyelgCdXaDqFp0t9OEft8RgfjG8RbwO0g=; b=WdYBfOGlojX9ZqStJz1WXUnBMUzLjdK/UCEb6Ud+cEJP3dGhy5l6Keo36jtRwRolDI 7zCbowej+lKkQ9Zmii6ybxQmoDVpRw+nPCHKdEUpVAuFgvZu4aQxYOigJUFR1UngqOCW fYp3Wed5OBfOfmpnsIrlyQF2PZ+M+OdXqylyroPTY6o/HJJu92n+LeCGezfhCHd8t85F UmmRR6QaHd5FwebIpksnyQiqZ3rSS0FiPgpMZH24bGh2YbdvOOlGojZSLjpzORg/XVda GAoXFcNvtwawh+MRfiaQ0PJI3mwoQz0vyl59HJINE/DuHGX133t2R4qt/X9nV8mCBbs8 +vfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rF2GOyv1qKGyelgCdXaDqFp0t9OEft8RgfjG8RbwO0g=; b=CzNuSlgSdxvhDm6gYaFxYxkfjuWOPkb8S81a9HzMqWSFQUmbJP/xrNE/+0dGLLGKbI bgmr54lJbR0cUOY9sjc641E382VyeD7kVWqw/yNFvg9t1tSzEDaWfFaXy4B5+zBHw3Kp 54kVsLSIdHZ1mCR1AUJbSJRQ888EYnjVmXp8nfvHyz69DGsxq7mwICVMIzbolBJdAzaJ IGKz59UsUbduNJTc5bcYvFNYWCRtlIASWA8ghGvSA73Qw0fY7/PguxRHw/V4rYuPQMBJ 2Fm32OQNWABaoGKc9KgUaNIe1cdHRKsIBaLON8kkEwGJL5lQ6cbRi0VY21igbit3dGEE v9tQ== X-Gm-Message-State: APjAAAW4C8JcrOzc7BTJF3czE+dpjjkBKJaEzmpRj1pTTV8QqTLaMu8T 47IBCMzix+eqagGaQIymRU47Ug== X-Google-Smtp-Source: APXvYqzESLZ8jsgLl2vRzwsDxjMT2dpWZawd9oCfmtbFbTfYjQgGcWbkV5MaIcusnw57GoneJeOMnQ== X-Received: by 2002:a05:600c:230d:: with SMTP id 13mr13680648wmo.13.1577955497057; Thu, 02 Jan 2020 00:58:17 -0800 (PST) Received: from dell ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id t125sm8025145wmf.17.2020.01.02.00.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 00:58:16 -0800 (PST) Date: Thu, 2 Jan 2020 08:58:28 +0000 From: Lee Jones To: Mika Westerberg Cc: Andy Shevchenko , Darren Hart , x86@kernel.org, Zha Qipeng , Rajneesh Bhardwaj , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/37] platform/x86: intel_scu_ipc: Split out SCU IPC functionality from the SCU driver Message-ID: <20200102085828.GC22390@dell> References: <20191223141716.13727-1-mika.westerberg@linux.intel.com> <20191223141716.13727-13-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191223141716.13727-13-mika.westerberg@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Dec 2019, Mika Westerberg wrote: > The SCU IPC functionality is usable outside of Intel MID devices. For > example modern Intel CPUs include the same thing but now it is called > PMC (Power Management Controller) instead of SCU. To make the IPC > available for those split the driver into library part (intel_scu_ipc.c) > and the SCU PCI driver part (intel_scu_pcidrv.c) which then calls the > former before it goes and creates rest of the SCU devices. > > We also split the Kconfig symbols so that INTEL_SCU_IPC enables the SCU > IPC library and INTEL_SCU_PCI the SCU driver and convert the users > accordingly. While there remove default y from the INTEL_SCU_PCI symbol > as it is already selected by X86_INTEL_MID. > > Signed-off-by: Mika Westerberg > --- > arch/x86/Kconfig | 2 +- > arch/x86/include/asm/intel_scu_ipc.h | 15 +++++ > drivers/mfd/Kconfig | 4 +- For my own reference: Acked-for-MFD-by: Lee Jones > drivers/platform/x86/Kconfig | 26 ++++++--- > drivers/platform/x86/Makefile | 1 + > drivers/platform/x86/intel_scu_ipc.c | 77 +++++++++---------------- > drivers/platform/x86/intel_scu_pcidrv.c | 61 ++++++++++++++++++++ > 7 files changed, 125 insertions(+), 61 deletions(-) > create mode 100644 drivers/platform/x86/intel_scu_pcidrv.c -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog