Re: [PATCH 4.19 054/114] scsi: scsi_debug: num_tgts must be >= 0

Pavel Machek
2020-01-03T16:34:08Z

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

Hi!

> From: Maurizio Lombardi <mlombard@redhat.com>
>
> [ Upstream commit aa5334c4f3014940f11bf876e919c956abef4089 ]
>
> Passing the parameter "num_tgts=-1" will start an infinite loop that
> exhausts the system memory

Should we provide some kind of upper bound for num_tgts, too?
Otherwise integer overflow will follow later in the code. Even without
overflow, it will kill the system due to OOM...

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]