From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ACD7C2D0C2 for ; Fri, 3 Jan 2020 11:32:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 134F624653 for ; Fri, 3 Jan 2020 11:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727641AbgACLb7 (ORCPT ); Fri, 3 Jan 2020 06:31:59 -0500 Received: from foss.arm.com ([217.140.110.172]:54830 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbgACLb6 (ORCPT ); Fri, 3 Jan 2020 06:31:58 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E5001FB; Fri, 3 Jan 2020 03:31:58 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 847E83F703; Fri, 3 Jan 2020 03:31:56 -0800 (PST) Date: Fri, 3 Jan 2020 11:31:51 +0000 From: Sudeep Holla To: Jolly Shah Cc: "ard.biesheuvel@linaro.org" , "mingo@kernel.org" , "gregkh@linuxfoundation.org" , "matt@codeblueprint.co.uk" , "hkallweit1@gmail.com" , "keescook@chromium.org" , "dmitry.torokhov@gmail.com" , Michal Simek , Rajan Vaja , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sudeep Holla Subject: Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface Message-ID: <20200103113151.GA19390@bogus> References: <1575502159-11327-1-git-send-email-jolly.shah@xilinx.com> <20191218144555.GA12525@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 02, 2020 at 09:01:58PM +0000, Jolly Shah wrote: > Hi Sudeep, > > Thanks for the review. > > > -----Original Message----- > > From: Sudeep Holla > > Sent: Wednesday, December 18, 2019 6:46 AM > > To: Jolly Shah > > Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; > > gregkh@linuxfoundation.org; matt@codeblueprint.co.uk; > > hkallweit1@gmail.com; keescook@chromium.org; > > dmitry.torokhov@gmail.com; Michal Simek ; Rajan Vaja > > ; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; Sudeep Holla > > Subject: Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface > > > > On Wed, Dec 04, 2019 at 03:29:14PM -0800, Jolly Shah wrote: > > > This patch series adds xilinx specific sysfs interface for below > > > purposes: > > > - Register access > > > - Set shutdown scope > > > - Set boot health status bit > > > > This series defeats the whole abstraction EEMI provides. By providing > > direct register accesses, you are allowing user-space to do whatever it > > wants. I had NACKed this idea before. Has anything changed ? > > > > Firmware checks for allowed accesses only and rejects rest. > If that is always the case, why not abstract them and remove this direct register access completely. It must go or we must remove EEMI abstraction and just provide direct register access to the entire space. I really don't like this mix-n-match approach here. > > If you need it for testing firmware, better put them in debugfs which is > > off on production builds. > > Sure. Will reanalyze use cases and move to debugfs only if that suffices. > Thanks. -- Regards, Sudeep