[PATCH] mfd: max77650: Select REGMAP_IRQ in Kconfig

[PATCH] mfd: max77650: Select REGMAP_IRQ in Kconfig

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

MAX77650 MFD driver uses regmap_irq API but doesn't select the required
REGMAP_IRQ option in Kconfig. This can cause the following build error
if regmap irq is not enabled implicitly by someone else:

    ld: drivers/mfd/max77650.o: in function `max77650_i2c_probe':
    max77650.c:(.text+0xcb): undefined reference to `devm_regmap_add_irq_chip'
    ld: max77650.c:(.text+0xdb): undefined reference to `regmap_irq_get_domain'
    make: *** [Makefile:1079: vmlinux] Error 1

Fix it by adding the missing option.

Fixes: d0f60334500b ("mfd: Add new driver for MAX77650 PMIC")
Reported-by: Paul Gazzillo <paul@pgazz.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 420900852166..c366503c466d 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -758,6 +758,7 @@ config MFD_MAX77650
 	depends on OF || COMPILE_TEST
 	select MFD_CORE
 	select REGMAP_I2C
+	select REGMAP_IRQ
 	help
 	  Say Y here to add support for Maxim Semiconductor MAX77650 and
 	  MAX77651 Power Management ICs. This is the core multifunction
-- 
2.23.0

Re: [PATCH] mfd: max77650: Select REGMAP_IRQ in Kconfig

[Lee Jones]

On Fri, 03 Jan 2020, Bartosz Golaszewski wrote:

> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> MAX77650 MFD driver uses regmap_irq API but doesn't select the required
> REGMAP_IRQ option in Kconfig. This can cause the following build error
> if regmap irq is not enabled implicitly by someone else:
> 
>     ld: drivers/mfd/max77650.o: in function `max77650_i2c_probe':
>     max77650.c:(.text+0xcb): undefined reference to `devm_regmap_add_irq_chip'
>     ld: max77650.c:(.text+0xdb): undefined reference to `regmap_irq_get_domain'
>     make: *** [Makefile:1079: vmlinux] Error 1
> 
> Fix it by adding the missing option.
> 
> Fixes: d0f60334500b ("mfd: Add new driver for MAX77650 PMIC")
> Reported-by: Paul Gazzillo <paul@pgazz.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog