public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Amrita Patole <longlivelinux@yahoo.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com,
	manishc@marvell.com, Amrita Patole <amritapatole@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com
Date: Fri, 3 Jan 2020 16:25:49 +0300	[thread overview]
Message-ID: <20200103132506.GK3911@kadam> (raw)
In-Reply-To: <20200102111653.GB3961630@kroah.com>

On Thu, Jan 02, 2020 at 12:16:53PM +0100, Greg KH wrote:
> On Thu, Jan 02, 2020 at 12:59:29PM +0530, Amrita Patole wrote:
> > From: Amrita Patole <amritapatole@gmail.com>
> > 
> > ---
> >  drivers/staging/qlge/qlge_mpi.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> > index 9e422bbbb6ab..f63db2c79fac 100644
> > --- a/drivers/staging/qlge/qlge_mpi.c
> > +++ b/drivers/staging/qlge/qlge_mpi.c
> > @@ -136,7 +136,8 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp)
> >  		    ql_read_mpi_reg(qdev, qdev->mailbox_out + i,
> >  				     &mbcp->mbox_out[i]);
> >  		if (status) {
> > -			netif_err(qdev, drv, qdev->ndev, "Failed mailbox read.\n");
> > +			netif_err(qdev, drv, qdev->ndev,
> > +                                  "Failed mailbox read. \n");


			netif_err(qdev, drv, qdev->ndev,
                                  "Failed mailbox read. \n");
				  "Failed mailbox read. \n");


I'm pretty sure this will introduce a couplee new checkpatch warnings...
It should be indented:
[tab][tab][tab][tab][space][space]"Failed mailbox read.\n");

No space after the period, please.

regards,
dan carpenter


      reply	other threads:[~2020-01-03 13:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200102072929.21636-1-longlivelinux.ref@yahoo.com>
     [not found] ` <20200102072929.21636-1-longlivelinux@yahoo.com>
2020-01-02 11:16   ` [PATCH] Fixing coding style. Signed-off-by: amritapatole@gmail.com Greg KH
2020-01-03 13:25     ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200103132506.GK3911@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=amritapatole@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longlivelinux@yahoo.com \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox