From: Jason Gunthorpe <jgg@ziepe.ca>
To: Aditya Pakki <pakki001@umn.edu>
Cc: kjlu@umn.edu, Bart Van Assche <bvanassche@acm.org>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: RDMA/srpt: remove unnecessary assertion in srpt_queue_response
Date: Fri, 3 Jan 2020 16:23:23 -0400 [thread overview]
Message-ID: <20200103202323.GA15557@ziepe.ca> (raw)
In-Reply-To: <20191217194437.25568-1-pakki001@umn.edu>
On Tue, Dec 17, 2019 at 01:44:37PM -0600, Aditya Pakki wrote:
> Currently, BUG_ON in srpt_queue_response, is used as an assertion for
> empty rdma channel. However, if the channel is NULL, the call trace
> on console is sufficient for diagnosis.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> ---
> v1: Avoid potential NULL pointer derefernce of ch. Current fix
> suggested by Bart Van Assche
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 2 --
> 1 file changed, 2 deletions(-)
Applied to for-next with the reworked commit message Bart suggested
Thanks,
Jason
prev parent reply other threads:[~2020-01-03 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 19:44 [PATCH v2] scsi: RDMA/srpt: remove unnecessary assertion in srpt_queue_response Aditya Pakki
2019-12-17 20:34 ` Bart Van Assche
2020-01-03 20:23 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103202323.GA15557@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox