From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39522C00523 for ; Fri, 3 Jan 2020 23:44:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFF5F21835 for ; Fri, 3 Jan 2020 23:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578095070; bh=Mg3TQ5nbJqbt3keDFCXdnTMad0SO85xjOLMwAZ4VpnU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dnxdWqCDjdRgnzsBGEjeIQGd9Br2SmpvFeClNqgfKTlNtLoAcmf0ogUCsfwiGTTGG Scd1146DQ3Y5y6AwqK5GJkRRquNMahder0k2E95aVtjNS1t2jUMjGRAXMOwgxDG6aQ 9avIDEGb+t/TGwospycofVQU74h7e4VMhWeBAIAM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbgACXo3 (ORCPT ); Fri, 3 Jan 2020 18:44:29 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:36420 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbgACXo2 (ORCPT ); Fri, 3 Jan 2020 18:44:28 -0500 Received: by mail-il1-f194.google.com with SMTP id b15so37986019iln.3 for ; Fri, 03 Jan 2020 15:44:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oHVJcbfywZ2wbBBx9DgqhrtkzwrTvD4xChukN5BH1kY=; b=aWa9DmXbrzJeX0JMNCjRNxi8NYUCuUttQRtX9qmIyA/lt+fqk/voar2ms2R6Dw/Lrl V/UMV6dTa+6OcuIgU0bf8JLTFDNlYmxpW0TTHhclMLNmCUVMb+OD03UqAQQ0DSaGIvQR wQ1xVK/V3jNszfeQHiJV5vKPQonv4Xvq8u1T82gw6iVylfskUjEsTdeq3tC5L8tgckkg Bne/T8kJVcKMD5sOm7JIcPXBwC7VcyjCEv8YDQ4lJ5aCm44pKBbA6WvzSUxtGhy7Aiqg Y8GB/pdyE09Y1bVyGl90pKG5RpUc+WuLk8nnK2ZAPQ04gVibIUFXQ4pbPXlHkRRIqdy5 umtA== X-Gm-Message-State: APjAAAUbgsZ5W7vsHOgmO5U0hpCWq1I8fcJD4Qj2vyg9nPy1mwqTQ1Rc FQs1KERRNCGueZCxh0x91Vo5UD0= X-Google-Smtp-Source: APXvYqxmYZYOXaED5KAXKD+3FhJf7pjVRcWo9dCOJi2lUv5WJ2GR0B/tEG/59HUkFsu4MzmWH28yGA== X-Received: by 2002:a92:d241:: with SMTP id v1mr58830649ilg.177.1578095067621; Fri, 03 Jan 2020 15:44:27 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id y9sm15218778ion.54.2020.01.03.15.44.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 15:44:26 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219b7 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 16:44:25 -0700 Date: Fri, 3 Jan 2020 16:44:25 -0700 From: Rob Herring To: Khouloud Touil Cc: bgolaszewski@baylibre.com, mark.rutland@arm.com, srinivas.kandagatla@linaro.org, baylibre-upstreaming@groups.io, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linus.walleij@linaro.org Subject: Re: [PATCH v3 3/4] dt-bindings: at24: remove the optional property write-protect-gpios Message-ID: <20200103234425.GA17746@bogus> References: <20191219115141.24653-1-ktouil@baylibre.com> <20191219115141.24653-4-ktouil@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191219115141.24653-4-ktouil@baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 19, 2019 at 12:51:40PM +0100, Khouloud Touil wrote: > NVMEM framework is an interface for the at24 EEPROMs as well as for > other drivers, instead of passing the wp-gpios over the different > drivers each time, it would be better to pass it over the NVMEM > subsystem once and for all. > > Removing the optional property form the device tree binding document. > > Signed-off-by: Khouloud Touil > Reviewed-by: Linus Walleij > --- > Documentation/devicetree/bindings/eeprom/at24.yaml | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml > index e8778560d966..75de83708146 100644 > --- a/Documentation/devicetree/bindings/eeprom/at24.yaml > +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml > @@ -145,10 +145,7 @@ properties: > over reads to the next slave address. Please consult the manual of > your device. > > - wp-gpios: > - description: > - GPIO to which the write-protect pin of the chip is connected. > - maxItems: 1 > + wp-gpios: true > > address-width: > allOf: > @@ -181,7 +178,6 @@ examples: > compatible = "microchip,24c32", "atmel,24c32"; > reg = <0x52>; > pagesize = <32>; > - wp-gpios = <&gpio1 3 0>; This is still valid, why is it being removed? > num-addresses = <8>; > }; > }; > -- > 2.17.1 >