From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA77C33C9A for ; Sun, 5 Jan 2020 11:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2616F217F4 for ; Sun, 5 Jan 2020 11:31:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726387AbgAELb5 (ORCPT ); Sun, 5 Jan 2020 06:31:57 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:35266 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725897AbgAELb4 (ORCPT ); Sun, 5 Jan 2020 06:31:56 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id BF8F820055; Sun, 5 Jan 2020 12:31:53 +0100 (CET) Date: Sun, 5 Jan 2020 12:31:52 +0100 From: Sam Ravnborg To: Jitao Shi Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, cawa.cheng@mediatek.com, bibby.hsieh@mediatek.com, linux-mediatek@lists.infradead.org, ck.hu@mediatek.com, stonea168@163.com Subject: Re: [PATCH v7 6/8] drm/panel: support for boe,tv101wum-n53 wuxga dsi video mode panel Message-ID: <20200105113152.GB16043@ravnborg.org> References: <20191012030720.27127-1-jitao.shi@mediatek.com> <20191012030720.27127-7-jitao.shi@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191012030720.27127-7-jitao.shi@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=mpaa-ttXAAAA:8 a=7gkXJVJtAAAA:8 a=8PYDNBx85CIz2eXB0hYA:9 a=CjuIK1q_8ugA:10 a=6heAxKwa5pAsJatQ0mat:22 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jitao. Looks good. On Sat, Oct 12, 2019 at 11:07:18AM +0800, Jitao Shi wrote: > Boe,tv101wum-n53's connector is same as boe,tv101wum-nl6. > The most codes can be reuse. > So boe,tv101wum-n53 and boe,tv101wum-nl6 use one driver file. > Add the different parts in driver data. > > Signed-off-by: Jitao Shi Reviewed-by: Sam Ravnborg > --- > .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > index e6457f87bc61..7b47619675f5 100644 > --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > @@ -624,6 +624,34 @@ static const struct panel_desc auo_kd101n80_45na_desc = { > .discharge_on_disable = true, > }; > > +static const struct drm_display_mode boe_tv101wum_n53_default_mode = { > + .clock = 159833, > + .hdisplay = 1200, > + .hsync_start = 1200 + 114, > + .hsync_end = 1200 + 114 + 10, > + .htotal = 1200 + 114 + 10 + 40, > + .vdisplay = 1920, > + .vsync_start = 1920 + 19, > + .vsync_end = 1920 + 19 + 4, > + .vtotal = 1920 + 19 + 4 + 10, > + .vrefresh = 60, > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > +}; > + > +static const struct panel_desc boe_tv101wum_n53_desc = { > + .modes = &boe_tv101wum_n53_default_mode, > + .bpc = 8, > + .size = { > + .width_mm = 135, > + .height_mm = 216, > + }, > + .lanes = 4, > + .format = MIPI_DSI_FMT_RGB888, > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > + MIPI_DSI_MODE_LPM, > + .init_cmds = boe_init_cmd, > +}; > + > static int boe_panel_get_modes(struct drm_panel *panel) > { > struct boe_panel *boe = to_boe_panel(panel); > @@ -751,6 +779,9 @@ static const struct of_device_id boe_of_match[] = { > { .compatible = "auo,kd101n80-45na", > .data = &auo_kd101n80_45na_desc > }, > + { .compatible = "boe,tv101wum-n53", > + .data = &boe_tv101wum_n53_desc > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, boe_of_match); > -- > 2.21.0