From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org,
Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
Cc: kbuild-all@lists.01.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, bhelgaas@google.com,
rgummal@xilinx.com,
Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
Subject: Re: [PATCH 2/2] PCI: Versal CPM: Add support for Versal CPM Root Port driver
Date: Sun, 5 Jan 2020 21:49:53 +0300 [thread overview]
Message-ID: <20200105184953.GF3889@kadam> (raw)
In-Reply-To: <1576842072-32027-3-git-send-email-bharat.kumar.gogada@xilinx.com>
Hi Bharat,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Bharat-Kumar-Gogada/Adding-support-for-versal-CPM-as-Root-Port-driver/20191223-193219
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/pci/controller/pcie-xilinx-cpm.c:330 xilinx_cpm_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
Old smatch warnings:
drivers/pci/controller/pcie-xilinx-cpm.c:338 xilinx_cpm_pcie_init_irq_domain() warn: passing zero to 'PTR_ERR'
# https://github.com/0day-ci/linux/commit/f107713acb796e598f16a23b33af74fa382921b2
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout f107713acb796e598f16a23b33af74fa382921b2
vim +/PTR_ERR +330 drivers/pci/controller/pcie-xilinx-cpm.c
f107713acb796e Bharat Kumar Gogada 2019-12-20 320 static int xilinx_cpm_pcie_init_irq_domain(struct xilinx_cpm_pcie_port *port)
f107713acb796e Bharat Kumar Gogada 2019-12-20 321 {
f107713acb796e Bharat Kumar Gogada 2019-12-20 322 struct device *dev = port->dev;
f107713acb796e Bharat Kumar Gogada 2019-12-20 323 struct device_node *node = dev->of_node;
f107713acb796e Bharat Kumar Gogada 2019-12-20 324 struct device_node *pcie_intc_node;
f107713acb796e Bharat Kumar Gogada 2019-12-20 325
f107713acb796e Bharat Kumar Gogada 2019-12-20 326 /* Setup INTx */
f107713acb796e Bharat Kumar Gogada 2019-12-20 327 pcie_intc_node = of_get_next_child(node, NULL);
f107713acb796e Bharat Kumar Gogada 2019-12-20 328 if (!pcie_intc_node) {
^^^^^^^^^^^^^^^
f107713acb796e Bharat Kumar Gogada 2019-12-20 329 dev_err(dev, "No PCIe Intc node found\n");
f107713acb796e Bharat Kumar Gogada 2019-12-20 @330 return PTR_ERR(pcie_intc_node);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
(This means success).
f107713acb796e Bharat Kumar Gogada 2019-12-20 331 }
f107713acb796e Bharat Kumar Gogada 2019-12-20 332
f107713acb796e Bharat Kumar Gogada 2019-12-20 333 port->leg_domain = irq_domain_add_linear(pcie_intc_node, INTX_NUM,
f107713acb796e Bharat Kumar Gogada 2019-12-20 334 &intx_domain_ops,
f107713acb796e Bharat Kumar Gogada 2019-12-20 335 port);
f107713acb796e Bharat Kumar Gogada 2019-12-20 336 if (!port->leg_domain) {
f107713acb796e Bharat Kumar Gogada 2019-12-20 337 dev_err(dev, "Failed to get a INTx IRQ domain\n");
f107713acb796e Bharat Kumar Gogada 2019-12-20 338 return PTR_ERR(port->leg_domain);
f107713acb796e Bharat Kumar Gogada 2019-12-20 339 }
f107713acb796e Bharat Kumar Gogada 2019-12-20 340
f107713acb796e Bharat Kumar Gogada 2019-12-20 341 return 0;
f107713acb796e Bharat Kumar Gogada 2019-12-20 342 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
next prev parent reply other threads:[~2020-01-05 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 11:41 [PATCH 0/2] Adding support for versal CPM as Root Port driver Bharat Kumar Gogada
2019-12-20 11:41 ` [PATCH 1/2] PCI: Versal CPM: Add device tree binding forversal CPM host controller Bharat Kumar Gogada
2020-02-25 10:58 ` Lorenzo Pieralisi
2020-02-25 13:53 ` Bharat Kumar Gogada
2019-12-20 11:41 ` [PATCH 2/2] PCI: Versal CPM: Add support for Versal CPM Root Port driver Bharat Kumar Gogada
2019-12-20 14:58 ` Bjorn Helgaas
2019-12-27 11:55 ` Bharat Kumar Gogada
2020-01-05 18:49 ` Dan Carpenter [this message]
2020-01-08 10:16 ` Bharat Kumar Gogada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200105184953.GF3889@kadam \
--to=dan.carpenter@oracle.com \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rgummal@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).