From: Lee Jones <lee.jones@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Paul Gazzillo <paul@pgazz.com>
Subject: Re: [PATCH] mfd: max77650: Select REGMAP_IRQ in Kconfig
Date: Mon, 6 Jan 2020 11:17:37 +0000 [thread overview]
Message-ID: <20200106111737.GB14821@dell> (raw)
In-Reply-To: <20200103114156.20089-1-brgl@bgdev.pl>
On Fri, 03 Jan 2020, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> MAX77650 MFD driver uses regmap_irq API but doesn't select the required
> REGMAP_IRQ option in Kconfig. This can cause the following build error
> if regmap irq is not enabled implicitly by someone else:
>
> ld: drivers/mfd/max77650.o: in function `max77650_i2c_probe':
> max77650.c:(.text+0xcb): undefined reference to `devm_regmap_add_irq_chip'
> ld: max77650.c:(.text+0xdb): undefined reference to `regmap_irq_get_domain'
> make: *** [Makefile:1079: vmlinux] Error 1
>
> Fix it by adding the missing option.
>
> Fixes: d0f60334500b ("mfd: Add new driver for MAX77650 PMIC")
> Reported-by: Paul Gazzillo <paul@pgazz.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-01-06 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 11:41 [PATCH] mfd: max77650: Select REGMAP_IRQ in Kconfig Bartosz Golaszewski
2020-01-06 11:17 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106111737.GB14821@dell \
--to=lee.jones@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pgazz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox