From: Alex Williamson <alex.williamson@redhat.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: kernel-janitors@vger.kernel.org,
Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] vfio/spapr_tce: use mmgrab
Date: Mon, 6 Jan 2020 16:05:07 -0700 [thread overview]
Message-ID: <20200106160507.3fc1712a@w520.home> (raw)
In-Reply-To: <1577634178-22530-4-git-send-email-Julia.Lawall@inria.fr>
On Sun, 29 Dec 2019 16:42:57 +0100
Julia Lawall <Julia.Lawall@inria.fr> wrote:
> Mmgrab was introduced in commit f1f1007644ff ("mm: add new mmgrab()
> helper") and most of the kernel was updated to use it. Update a
> remaining file.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> <smpl>
> @@ expression e; @@
> - atomic_inc(&e->mm_count);
> + mmgrab(e);
> </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> drivers/vfio/vfio_iommu_spapr_tce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
> index 26cef65b41e7..16b3adc508db 100644
> --- a/drivers/vfio/vfio_iommu_spapr_tce.c
> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c
> @@ -79,7 +79,7 @@ static long tce_iommu_mm_set(struct tce_container *container)
> }
> BUG_ON(!current->mm);
> container->mm = current->mm;
> - atomic_inc(&container->mm->mm_count);
> + mmgrab(container->mm);
>
> return 0;
> }
>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
next prev parent reply other threads:[~2020-01-06 23:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 15:42 [PATCH 0/4] use mmgrab Julia Lawall
2019-12-29 15:42 ` [PATCH 1/4] misc: cxl: " Julia Lawall
2019-12-29 22:38 ` Andrew Donnellan
2020-01-29 5:17 ` Michael Ellerman
2019-12-29 15:42 ` [PATCH 2/4] vfio: vfio_pci_nvlink2: " Julia Lawall
2020-01-06 23:05 ` Alex Williamson
2020-01-07 5:51 ` Dan Carpenter
2020-01-07 17:00 ` Julia Lawall
2020-01-07 17:10 ` Alex Williamson
2020-01-07 9:14 ` Cornelia Huck
2019-12-29 15:42 ` [PATCH 3/4] vfio/spapr_tce: " Julia Lawall
2020-01-06 23:05 ` Alex Williamson [this message]
2020-01-07 9:14 ` Cornelia Huck
2019-12-29 15:42 ` [PATCH 4/4] openrisc: " Julia Lawall
2019-12-30 4:49 ` kbuild test robot
2020-01-06 14:53 ` Stafford Horne
2020-01-31 13:25 ` Stafford Horne
2020-01-03 12:31 ` [PATCH 0/4] " Dan Carpenter
2020-01-03 12:47 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106160507.3fc1712a@w520.home \
--to=alex.williamson@redhat.com \
--cc=Julia.Lawall@inria.fr \
--cc=cohuck@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox