From: Alex Williamson <alex.williamson@redhat.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: kernel-janitors@vger.kernel.org,
Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] vfio: vfio_pci_nvlink2: use mmgrab
Date: Tue, 7 Jan 2020 10:10:51 -0700 [thread overview]
Message-ID: <20200107101051.6d3cd526@w520.home> (raw)
In-Reply-To: <alpine.DEB.2.21.2001071800090.3004@hadrien>
On Tue, 7 Jan 2020 18:00:31 +0100 (CET)
Julia Lawall <julia.lawall@inria.fr> wrote:
> On Mon, 6 Jan 2020, Alex Williamson wrote:
>
> > On Sun, 29 Dec 2019 16:42:56 +0100
> > Julia Lawall <Julia.Lawall@inria.fr> wrote:
> >
> > > Mmgrab was introduced in commit f1f1007644ff ("mm: add new mmgrab()
> > > helper") and most of the kernel was updated to use it. Update a
> > > remaining file.
> > >
> > > The semantic patch that makes this change is as follows:
> > > (http://coccinelle.lip6.fr/)
> > >
> > > <smpl>
> > > @@ expression e; @@
> > > - atomic_inc(&e->mm_count);
> > > + mmgrab(e);
> > > </smpl>
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> > >
> > > ---
> > > drivers/vfio/pci/vfio_pci_nvlink2.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c
> > > index f2983f0f84be..43df10af7f66 100644
> > > --- a/drivers/vfio/pci/vfio_pci_nvlink2.c
> > > +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
> > > @@ -159,7 +159,7 @@ static int vfio_pci_nvgpu_mmap(struct vfio_pci_device *vdev,
> > > data->useraddr = vma->vm_start;
> > > data->mm = current->mm;
> > >
> > > - atomic_inc(&data->mm->mm_count);
> > > + mmgrab(data->mm);
> > > ret = (int) mm_iommu_newdev(data->mm, data->useraddr,
> > > vma_pages(vma), data->gpu_hpa, &data->mem);
> > >
> > >
> >
> > Acked-by: Alex Williamson <alex.williamson@redhat.com>
> >
> > Thanks! I'm assuming these will be routed via janitors tree, please
> > let me know if you intend me to grab these two vfio patches from the
> > series. Thanks,
>
> Please take them directly.
Ok, I'll queue patches 2 & 3 for v5.6. Thanks,
Alex
next prev parent reply other threads:[~2020-01-07 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 15:42 [PATCH 0/4] use mmgrab Julia Lawall
2019-12-29 15:42 ` [PATCH 1/4] misc: cxl: " Julia Lawall
2019-12-29 22:38 ` Andrew Donnellan
2020-01-29 5:17 ` Michael Ellerman
2019-12-29 15:42 ` [PATCH 2/4] vfio: vfio_pci_nvlink2: " Julia Lawall
2020-01-06 23:05 ` Alex Williamson
2020-01-07 5:51 ` Dan Carpenter
2020-01-07 17:00 ` Julia Lawall
2020-01-07 17:10 ` Alex Williamson [this message]
2020-01-07 9:14 ` Cornelia Huck
2019-12-29 15:42 ` [PATCH 3/4] vfio/spapr_tce: " Julia Lawall
2020-01-06 23:05 ` Alex Williamson
2020-01-07 9:14 ` Cornelia Huck
2019-12-29 15:42 ` [PATCH 4/4] openrisc: " Julia Lawall
2019-12-30 4:49 ` kbuild test robot
2020-01-06 14:53 ` Stafford Horne
2020-01-31 13:25 ` Stafford Horne
2020-01-03 12:31 ` [PATCH 0/4] " Dan Carpenter
2020-01-03 12:47 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107101051.6d3cd526@w520.home \
--to=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox