From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sekhar Nori <nsekhar@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] usb: ohci-da8xx: ensure error return on variable error is set
Date: Tue, 7 Jan 2020 15:10:10 +0300 [thread overview]
Message-ID: <20200107121010.GN3911@kadam> (raw)
In-Reply-To: <20200107103035.19481-1-colin.king@canonical.com>
On Tue, Jan 07, 2020 at 10:30:35AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently when an error in da8xx_ohci->oc_gpio occurs it causes an
> uninitialized error return in variable 'error' to be returned. Fix
> this by ensuring the error variable is set to the error value in
> da8xx_ohci->oc_gpio.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: d193abf1c913 ("usb: ohci-da8xx: add vbus and overcurrent gpios")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>
> V2: fix typo and grammar in commit message
>
> ---
> drivers/usb/host/ohci-da8xx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c
> index 38183ac438c6..9cdf787055b7 100644
> --- a/drivers/usb/host/ohci-da8xx.c
> +++ b/drivers/usb/host/ohci-da8xx.c
> @@ -415,8 +415,10 @@ static int ohci_da8xx_probe(struct platform_device *pdev)
> }
>
> da8xx_ohci->oc_gpio = devm_gpiod_get_optional(dev, "oc", GPIOD_IN);
> - if (IS_ERR(da8xx_ohci->oc_gpio))
> + if (IS_ERR(da8xx_ohci->oc_gpio)) {
> + error = PTR_ERR(da8xx_ohci->oc_gpio);
> goto err;
> + }
>
> if (da8xx_ohci->oc_gpio) {
> oc_irq = gpiod_to_irq(da8xx_ohci->oc_gpio);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Also uninitialized here.
regards,
dan carpenter
prev parent reply other threads:[~2020-01-07 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 10:30 [PATCH][V2] usb: ohci-da8xx: ensure error return on variable error is set Colin King
2020-01-07 12:10 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107121010.GN3911@kadam \
--to=dan.carpenter@oracle.com \
--cc=bgolaszewski@baylibre.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox