* [PATCH] mfd: tqmx86: remove set but not used variable 'i2c_ien'
@ 2020-01-03 12:09 yu kuai
2020-01-07 14:21 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: yu kuai @ 2020-01-03 12:09 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, yukuai3, yi.zhang, zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/mfd/tqmx86.c: In function ‘tqmx86_probe’:
drivers/mfd/tqmx86.c:161:29: warning: variable ‘i2c_ien’
set but not used I[-Wunused-but-set-variable]
It is never used, and so can be removed.
Signed-off-by: yu kuai <yukuai3@huawei.com>
---
drivers/mfd/tqmx86.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c
index 22d2f02d855c..b9f48e588d95 100644
--- a/drivers/mfd/tqmx86.c
+++ b/drivers/mfd/tqmx86.c
@@ -158,7 +158,7 @@ static int tqmx86_board_id_to_clk_rate(u8 board_id)
static int tqmx86_probe(struct platform_device *pdev)
{
- u8 board_id, rev, i2c_det, i2c_ien, io_ext_int_val;
+ u8 board_id, rev, i2c_det, io_ext_int_val;
struct device *dev = &pdev->dev;
u8 gpio_irq_cfg, readback;
const char *board_name;
@@ -196,7 +196,6 @@ static int tqmx86_probe(struct platform_device *pdev)
board_name, board_id, rev >> 4, rev & 0xf);
i2c_det = ioread8(io_base + TQMX86_REG_I2C_DETECT);
- i2c_ien = ioread8(io_base + TQMX86_REG_I2C_INT_EN);
if (gpio_irq_cfg) {
io_ext_int_val =
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: tqmx86: remove set but not used variable 'i2c_ien'
2020-01-03 12:09 [PATCH] mfd: tqmx86: remove set but not used variable 'i2c_ien' yu kuai
@ 2020-01-07 14:21 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-01-07 14:21 UTC (permalink / raw)
To: yu kuai; +Cc: linux-kernel, yi.zhang, zhengbin13
On Fri, 03 Jan 2020, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/mfd/tqmx86.c: In function ‘tqmx86_probe’:
> drivers/mfd/tqmx86.c:161:29: warning: variable ‘i2c_ien’
> set but not used I[-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> drivers/mfd/tqmx86.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-07 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-03 12:09 [PATCH] mfd: tqmx86: remove set but not used variable 'i2c_ien' yu kuai
2020-01-07 14:21 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox