From: Tejun Heo <tj@kernel.org>
To: mateusznosek0@gmail.com
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] fs/kernfs/dir.c: Clean code by removing always true condition
Date: Tue, 7 Jan 2020 07:51:10 -0800 [thread overview]
Message-ID: <20200107155110.GA2677547@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20191230191628.21099-1-mateusznosek0@gmail.com>
On Mon, Dec 30, 2019 at 08:16:28PM +0100, mateusznosek0@gmail.com wrote:
> From: Mateusz Nosek <mateusznosek0@gmail.com>
>
> Previously there was an additional check if variable pos is not null.
> However, this check happens after entering while loop and only then,
> which can happen only if pos is not null.
> Therefore the additional check is redundant and can be removed.
>
> Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Greg, can you please route this one?
Thanks.
--
tejun
next prev parent reply other threads:[~2020-01-07 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 19:16 [PATCH] fs/kernfs/dir.c: Clean code by removing always true condition mateusznosek0
2020-01-07 15:51 ` Tejun Heo [this message]
2020-01-07 21:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107155110.GA2677547@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusznosek0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox