From: Tianlin Li <tli@digitalocean.com>
To: kernel-hardening@lists.openwall.com, keescook@chromium.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
christian.koenig@amd.com, David1.Zhou@amd.com,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Tianlin Li <tli@digitalocean.com>
Subject: [PATCH 2/2] drm/radeon: change call sites to handle return value properly.
Date: Tue, 7 Jan 2020 13:25:55 -0600 [thread overview]
Message-ID: <20200107192555.20606-3-tli@digitalocean.com> (raw)
In-Reply-To: <20200107192555.20606-1-tli@digitalocean.com>
Ideally, the failure of set_memory_*() should be passed up the call stack,
and callers should examine the failure and deal with it. Fix those call
sites in drm/radeon to handle retval properly.
Since fini functions are always void, print errors for the failures.
Signed-off-by: Tianlin Li <tli@digitalocean.com>
---
drivers/gpu/drm/radeon/r100.c | 3 ++-
drivers/gpu/drm/radeon/rs400.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
index 110fb38004b1..7eafe15ba124 100644
--- a/drivers/gpu/drm/radeon/r100.c
+++ b/drivers/gpu/drm/radeon/r100.c
@@ -706,7 +706,8 @@ void r100_pci_gart_fini(struct radeon_device *rdev)
{
radeon_gart_fini(rdev);
r100_pci_gart_disable(rdev);
- radeon_gart_table_ram_free(rdev);
+ if (radeon_gart_table_ram_free(rdev))
+ DRM_ERROR("radeon: failed free system ram for GART page table.\n");
}
int r100_irq_set(struct radeon_device *rdev)
diff --git a/drivers/gpu/drm/radeon/rs400.c b/drivers/gpu/drm/radeon/rs400.c
index 117f60af1ee4..de3674f5fe23 100644
--- a/drivers/gpu/drm/radeon/rs400.c
+++ b/drivers/gpu/drm/radeon/rs400.c
@@ -210,7 +210,8 @@ void rs400_gart_fini(struct radeon_device *rdev)
{
radeon_gart_fini(rdev);
rs400_gart_disable(rdev);
- radeon_gart_table_ram_free(rdev);
+ if (radeon_gart_table_ram_free(rdev))
+ DRM_ERROR("radeon: failed free system ram for GART page table.\n");
}
#define RS400_PTE_UNSNOOPED (1 << 0)
--
2.17.1
next prev parent reply other threads:[~2020-01-07 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 19:25 [PATCH 0/2] drm/radeon: have the callers of set_memory_*() check the return value Tianlin Li
2020-01-07 19:25 ` [PATCH 1/2] " Tianlin Li
2020-01-07 19:25 ` Tianlin Li [this message]
2020-01-08 12:56 ` [PATCH 0/2] " Christian König
2020-01-08 17:39 ` Kees Cook
2020-01-08 17:51 ` Alex Deucher
2020-01-09 10:15 ` Christian König
2020-01-09 10:49 ` Thomas Zimmermann
2020-01-09 20:16 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107192555.20606-3-tli@digitalocean.com \
--to=tli@digitalocean.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox