From: Andrew Lunn <andrew@lunn.ch>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/12] i2c: ocores: convert to use i2c_new_client_device()
Date: Tue, 7 Jan 2020 20:36:47 +0100 [thread overview]
Message-ID: <20200107193647.GA16895@lunn.ch> (raw)
In-Reply-To: <87muazjewd.fsf@dell.be.48ers.dk>
On Tue, Jan 07, 2020 at 07:32:50PM +0100, Peter Korsgaard wrote:
> >>>>> "Wolfram" == Wolfram Sang <wsa+renesas@sang-engineering.com> writes:
>
> > Move away from the deprecated API and return the shiny new ERRPTR where
> > useful.
>
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> I didn't follow the discussion, but I don't see any returns anywhere?
Hi Peter
I have also not been following the discussion. But i2c_new_device()
seems to of always returned a NULL pointer on error, and the code has
been ignoring it. The 'where useful' comment suggests the return value
maybe checked, but it is optional to check it. So this patch seems
O.K.
I suppose the commit message could be extended with:
In this case, the shiny new stuff is not useful, so ignore it.
But:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-01-07 19:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 17:47 [PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device() Wolfram Sang
2020-01-07 17:47 ` [PATCH 01/12] i2c: cht-wc: convert " Wolfram Sang
2020-01-09 23:05 ` Hans de Goede
2020-01-07 17:47 ` [PATCH 02/12] i2c: i801: " Wolfram Sang
2020-01-09 8:54 ` Jean Delvare
2020-01-07 17:47 ` [PATCH 03/12] i2c: nvidia-gpu: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 04/12] i2c: ocores: " Wolfram Sang
2020-01-07 18:32 ` Peter Korsgaard
2020-01-07 19:31 ` Wolfram Sang
2020-01-07 19:58 ` Peter Korsgaard
2020-01-07 19:36 ` Andrew Lunn [this message]
2020-01-07 17:47 ` [PATCH 05/12] i2c: powermac: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 06/12] i2c: taos-evm: " Wolfram Sang
2020-01-08 10:58 ` Jean Delvare
2020-01-09 8:42 ` Jean Delvare
2020-01-15 19:56 ` Wolfram Sang
2020-01-07 17:47 ` [PATCH 07/12] i2c: xiic: " Wolfram Sang
2020-01-08 11:39 ` Michal Simek
2020-01-07 17:47 ` [PATCH 08/12] i2c: i2c-core-acpi: " Wolfram Sang
2020-01-08 10:04 ` Mika Westerberg
2020-01-07 17:47 ` [PATCH 09/12] i2c: i2c-core-base: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 10/12] i2c: i2c-core-of: " Wolfram Sang
2020-01-07 17:47 ` [PATCH 11/12] docs: i2c: use the new API in 'instantiating-devices.rst' Wolfram Sang
2020-01-07 17:47 ` [PATCH 12/12] docs: i2c: use the new API in 'writing-clients' Wolfram Sang
2020-01-15 19:57 ` [PATCH 00/12] i2c: convert subsystem to use i2c_new_client_device() Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107193647.GA16895@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox