From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Todd Kjos <tkjos@google.com>,
Alistair Delva <adelva@google.com>,
Amit Pundir <amit.pundir@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2] reset: qcom-aoss: Allow CONFIG_RESET_QCOM_AOSS to be a tristate
Date: Tue, 7 Jan 2020 16:02:51 -0800 [thread overview]
Message-ID: <20200108000251.GE738324@yoga> (raw)
In-Reply-To: <20200107191331.8930-1-john.stultz@linaro.org>
On Tue 07 Jan 11:13 PST 2020, John Stultz wrote:
> Allow CONFIG_RESET_QCOM_AOSS to be set as as =m
> to allow for the driver to be loaded from a modules.
>
> Also replaces the builtin_platform_driver() line with
> module_platform_driver()
>
> Cc: Todd Kjos <tkjos@google.com>
> Cc: Alistair Delva <adelva@google.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Amit Pundir <amit.pundir@linaro.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> v2: Fix builtin_platform_driver line in driver code
> ---
> drivers/reset/Kconfig | 2 +-
> drivers/reset/reset-qcom-aoss.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 3ad7817ce1f0..45e70524af36 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -99,7 +99,7 @@ config RESET_PISTACHIO
> This enables the reset driver for ImgTec Pistachio SoCs.
>
> config RESET_QCOM_AOSS
> - bool "Qcom AOSS Reset Driver"
> + tristate "Qcom AOSS Reset Driver"
> depends on ARCH_QCOM || COMPILE_TEST
> help
> This enables the AOSS (always on subsystem) reset driver
> diff --git a/drivers/reset/reset-qcom-aoss.c b/drivers/reset/reset-qcom-aoss.c
> index 36db96750450..76367f17fc73 100644
> --- a/drivers/reset/reset-qcom-aoss.c
> +++ b/drivers/reset/reset-qcom-aoss.c
> @@ -127,7 +127,7 @@ static struct platform_driver qcom_aoss_reset_driver = {
> },
> };
>
> -builtin_platform_driver(qcom_aoss_reset_driver);
> +module_platform_driver(qcom_aoss_reset_driver);
Thought we had this covered already, sorry for missing it yesterday.
In addition to module_platform_driver() you also need a
MODULE_DEVICE_TABLE(of, qcom_aoss_reset_of_match), or the driver won't
be loaded automatically.
Regards,
Bjorn
prev parent reply other threads:[~2020-01-08 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 19:13 [PATCH v2] reset: qcom-aoss: Allow CONFIG_RESET_QCOM_AOSS to be a tristate John Stultz
2020-01-08 0:02 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108000251.GE738324@yoga \
--to=bjorn.andersson@linaro.org \
--cc=adelva@google.com \
--cc=amit.pundir@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox