From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A2CC00523 for ; Wed, 8 Jan 2020 10:58:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A5112072A for ; Wed, 8 Jan 2020 10:58:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727824AbgAHK6Z (ORCPT ); Wed, 8 Jan 2020 05:58:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:34348 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbgAHK6Z (ORCPT ); Wed, 8 Jan 2020 05:58:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 582E2AD54; Wed, 8 Jan 2020 10:58:23 +0000 (UTC) Date: Wed, 8 Jan 2020 11:58:22 +0100 From: Jean Delvare To: Wolfram Sang Cc: , Subject: Re: [PATCH 06/12] i2c: taos-evm: convert to use i2c_new_client_device() Message-ID: <20200108115822.20871d77@endymion> In-Reply-To: <20200107174748.9616-7-wsa+renesas@sang-engineering.com> References: <20200107174748.9616-1-wsa+renesas@sang-engineering.com> <20200107174748.9616-7-wsa+renesas@sang-engineering.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Tue, 7 Jan 2020 18:47:40 +0100, Wolfram Sang wrote: > Move away from the deprecated API and return the shiny new ERRPTR where > useful. > > Signed-off-by: Wolfram Sang > --- > Build tested only. > > drivers/i2c/busses/i2c-taos-evm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c > index 0bff3f3a8779..b4050f5b6746 100644 > --- a/drivers/i2c/busses/i2c-taos-evm.c > +++ b/drivers/i2c/busses/i2c-taos-evm.c > @@ -49,10 +49,10 @@ static struct i2c_client *taos_instantiate_device(struct i2c_adapter *adapter) > if (!strncmp(adapter->name, "TAOS TSL2550 EVM", 16)) { > dev_info(&adapter->dev, "Instantiating device %s at 0x%02x\n", > tsl2550_info.type, tsl2550_info.addr); > - return i2c_new_device(adapter, &tsl2550_info); > + return i2c_new_client_device(adapter, &tsl2550_info); > } > > - return NULL; > + return ERR_PTR(-ENODEV); > } > > static int taos_smbus_xfer(struct i2c_adapter *adapter, u16 addr, Looks good to me, although ideally the caller should handle the error instead of ignoring it. But that's out of scope for this conversion patch, I'll look into submitting an update on top. So: Reviewed-by: Jean Delvare I'll also try to revive my evaluation module to give it some testing. Thanks, -- Jean Delvare SUSE L3 Support