From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 11/13] gpiolib: provide a dedicated function for setting lineinfo
Date: Wed, 8 Jan 2020 14:41:51 +0200 [thread overview]
Message-ID: <20200108124151.GQ32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191224120709.18247-12-brgl@bgdev.pl>
On Tue, Dec 24, 2019 at 01:07:07PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We'll soon be filling out the gpioline_info structure in multiple
> places. Add a separate function that given a gpio_desc sets all relevant
> fields.
>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/gpio/gpiolib.c | 98 ++++++++++++++++++++++++------------------
> 1 file changed, 55 insertions(+), 43 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 543244355e1c..276a7068f23c 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1148,6 +1148,60 @@ static int lineevent_create(struct gpio_device *gdev, void __user *ip)
> return ret;
> }
>
> +static void gpio_desc_to_lineinfo(struct gpio_desc *desc,
> + struct gpioline_info *info)
> +{
> + struct gpio_chip *chip = desc->gdev->chip;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&gpio_lock, flags);
> +
> + if (desc->name) {
> + strncpy(info->name, desc->name, sizeof(info->name));
> + info->name[sizeof(info->name) - 1] = '\0';
> + } else {
> + info->name[0] = '\0';
> + }
> +
> + if (desc->label) {
> + strncpy(info->consumer, desc->label, sizeof(info->consumer));
> + info->consumer[sizeof(info->consumer) - 1] = '\0';
> + } else {
> + info->consumer[0] = '\0';
> + }
> +
> + /*
> + * Userspace only need to know that the kernel is using this GPIO so
> + * it can't use it.
> + */
> + info->flags = 0;
> + if (test_bit(FLAG_REQUESTED, &desc->flags) ||
> + test_bit(FLAG_IS_HOGGED, &desc->flags) ||
> + test_bit(FLAG_USED_AS_IRQ, &desc->flags) ||
> + test_bit(FLAG_EXPORT, &desc->flags) ||
> + test_bit(FLAG_SYSFS, &desc->flags) ||
> + !pinctrl_gpio_can_use_line(chip->base + info->line_offset))
> + info->flags |= GPIOLINE_FLAG_KERNEL;
> + if (test_bit(FLAG_IS_OUT, &desc->flags))
> + info->flags |= GPIOLINE_FLAG_IS_OUT;
> + if (test_bit(FLAG_ACTIVE_LOW, &desc->flags))
> + info->flags |= GPIOLINE_FLAG_ACTIVE_LOW;
> + if (test_bit(FLAG_OPEN_DRAIN, &desc->flags))
> + info->flags |= (GPIOLINE_FLAG_OPEN_DRAIN |
> + GPIOLINE_FLAG_IS_OUT);
> + if (test_bit(FLAG_OPEN_SOURCE, &desc->flags))
> + info->flags |= (GPIOLINE_FLAG_OPEN_SOURCE |
> + GPIOLINE_FLAG_IS_OUT);
> + if (test_bit(FLAG_BIAS_DISABLE, &desc->flags))
> + info->flags |= GPIOLINE_FLAG_BIAS_DISABLE;
> + if (test_bit(FLAG_PULL_DOWN, &desc->flags))
> + info->flags |= GPIOLINE_FLAG_BIAS_PULL_DOWN;
> + if (test_bit(FLAG_PULL_UP, &desc->flags))
> + info->flags |= GPIOLINE_FLAG_BIAS_PULL_UP;
> +
> + spin_unlock_irqrestore(&gpio_lock, flags);
> +}
> +
> /*
> * gpio_ioctl() - ioctl handler for the GPIO chardev
> */
> @@ -1188,49 +1242,7 @@ static long gpio_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> if (IS_ERR(desc))
> return PTR_ERR(desc);
>
> - if (desc->name) {
> - strncpy(lineinfo.name, desc->name,
> - sizeof(lineinfo.name));
> - lineinfo.name[sizeof(lineinfo.name)-1] = '\0';
> - } else {
> - lineinfo.name[0] = '\0';
> - }
> - if (desc->label) {
> - strncpy(lineinfo.consumer, desc->label,
> - sizeof(lineinfo.consumer));
> - lineinfo.consumer[sizeof(lineinfo.consumer)-1] = '\0';
> - } else {
> - lineinfo.consumer[0] = '\0';
> - }
> -
> - /*
> - * Userspace only need to know that the kernel is using
> - * this GPIO so it can't use it.
> - */
> - lineinfo.flags = 0;
> - if (test_bit(FLAG_REQUESTED, &desc->flags) ||
> - test_bit(FLAG_IS_HOGGED, &desc->flags) ||
> - test_bit(FLAG_USED_AS_IRQ, &desc->flags) ||
> - test_bit(FLAG_EXPORT, &desc->flags) ||
> - test_bit(FLAG_SYSFS, &desc->flags) ||
> - !pinctrl_gpio_can_use_line(chip->base + lineinfo.line_offset))
> - lineinfo.flags |= GPIOLINE_FLAG_KERNEL;
> - if (test_bit(FLAG_IS_OUT, &desc->flags))
> - lineinfo.flags |= GPIOLINE_FLAG_IS_OUT;
> - if (test_bit(FLAG_ACTIVE_LOW, &desc->flags))
> - lineinfo.flags |= GPIOLINE_FLAG_ACTIVE_LOW;
> - if (test_bit(FLAG_OPEN_DRAIN, &desc->flags))
> - lineinfo.flags |= (GPIOLINE_FLAG_OPEN_DRAIN |
> - GPIOLINE_FLAG_IS_OUT);
> - if (test_bit(FLAG_OPEN_SOURCE, &desc->flags))
> - lineinfo.flags |= (GPIOLINE_FLAG_OPEN_SOURCE |
> - GPIOLINE_FLAG_IS_OUT);
> - if (test_bit(FLAG_BIAS_DISABLE, &desc->flags))
> - lineinfo.flags |= GPIOLINE_FLAG_BIAS_DISABLE;
> - if (test_bit(FLAG_PULL_DOWN, &desc->flags))
> - lineinfo.flags |= GPIOLINE_FLAG_BIAS_PULL_DOWN;
> - if (test_bit(FLAG_PULL_UP, &desc->flags))
> - lineinfo.flags |= GPIOLINE_FLAG_BIAS_PULL_UP;
> + gpio_desc_to_lineinfo(desc, &lineinfo);
>
> if (copy_to_user(ip, &lineinfo, sizeof(lineinfo)))
> return -EFAULT;
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-01-08 12:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 12:06 [PATCH v4 00/13] gpiolib: add an ioctl() for monitoring line status changes Bartosz Golaszewski
2019-12-24 12:06 ` [PATCH v4 01/13] gpiolib: use 'unsigned int' instead of 'unsigned' in gpio_set_config() Bartosz Golaszewski
2020-01-07 10:02 ` Linus Walleij
2019-12-24 12:06 ` [PATCH v4 02/13] gpiolib: have a single place of calling set_config() Bartosz Golaszewski
2020-01-07 10:02 ` Linus Walleij
2020-01-20 8:44 ` Geert Uytterhoeven
2020-01-20 9:54 ` Andy Shevchenko
2020-01-23 10:16 ` Bartosz Golaszewski
2020-02-01 19:52 ` Guenter Roeck
2020-02-03 11:04 ` Bartosz Golaszewski
2019-12-24 12:06 ` [PATCH v4 03/13] gpiolib: convert the type of hwnum to unsigned int in gpiochip_get_desc() Bartosz Golaszewski
2020-01-07 10:03 ` Linus Walleij
2019-12-24 12:07 ` [PATCH v4 04/13] gpiolib: use gpiochip_get_desc() in linehandle_create() Bartosz Golaszewski
2020-01-07 10:04 ` Linus Walleij
2019-12-24 12:07 ` [PATCH v4 05/13] gpiolib: use gpiochip_get_desc() in lineevent_create() Bartosz Golaszewski
2020-01-07 10:04 ` Linus Walleij
2019-12-24 12:07 ` [PATCH v4 06/13] gpiolib: use gpiochip_get_desc() in gpio_ioctl() Bartosz Golaszewski
2020-01-07 10:04 ` Linus Walleij
2019-12-24 12:07 ` [PATCH v4 07/13] kfifo: provide noirqsave variants of spinlocked in and out helpers Bartosz Golaszewski
2019-12-24 12:07 ` [PATCH v4 08/13] kfifo: provide kfifo_is_empty_spinlocked() Bartosz Golaszewski
2019-12-24 12:07 ` [PATCH v4 09/13] gpiolib: rework the locking mechanism for lineevent kfifo Bartosz Golaszewski
2020-01-08 11:06 ` Andy Shevchenko
2019-12-24 12:07 ` [PATCH v4 10/13] gpiolib: emit a debug message when adding events to a full kfifo Bartosz Golaszewski
2019-12-24 12:07 ` [PATCH v4 11/13] gpiolib: provide a dedicated function for setting lineinfo Bartosz Golaszewski
2020-01-08 12:41 ` Andy Shevchenko [this message]
2019-12-24 12:07 ` [PATCH v4 12/13] gpiolib: add new ioctl() for monitoring changes in line info Bartosz Golaszewski
2020-01-08 12:46 ` Andy Shevchenko
2020-01-08 16:55 ` Bartosz Golaszewski
2020-06-09 0:23 ` Kent Gibson
2020-06-09 7:58 ` Bartosz Golaszewski
2019-12-24 12:07 ` [PATCH v4 13/13] tools: gpio: implement gpio-watch Bartosz Golaszewski
2020-01-08 12:47 ` Andy Shevchenko
2020-01-07 10:07 ` [PATCH v4 00/13] gpiolib: add an ioctl() for monitoring line status changes Linus Walleij
2020-01-07 10:38 ` Bartosz Golaszewski
2020-01-07 12:50 ` Linus Walleij
2020-01-07 13:15 ` Stefani Seibold
2020-01-07 14:44 ` Andy Shevchenko
2020-01-07 14:45 ` Andy Shevchenko
2020-01-07 15:19 ` Bartosz Golaszewski
2020-01-07 15:58 ` Andy Shevchenko
2020-01-07 16:51 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108124151.GQ32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox