From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 290FEC33CA1 for ; Wed, 8 Jan 2020 12:59:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F079920720 for ; Wed, 8 Jan 2020 12:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578488344; bh=Or18NYoRhno1YFa4xw03vLiWPF2Fxp4A3Mm81c8PIao=; h=From:To:Cc:Subject:Date:List-ID:From; b=ZhmvbKmxaPwycFLoIsOfqFrOFR0ekiz/Dhf1N3S9Oi2cSncI6Xn3aW5NXTuNPr7ru Et4XCsbC9q3czKn69ROt6gQMCC1ZTzj94XE4zy7IPsx1i1gD8IazGo0uUT9C/64LLU P4iN2iC5ReHajkMuWGMcefgBfHn9do2xiVVCrWK0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727230AbgAHM7D (ORCPT ); Wed, 8 Jan 2020 07:59:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:58502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbgAHM7B (ORCPT ); Wed, 8 Jan 2020 07:59:01 -0500 Received: from aquarius.haifa.ibm.com (nesher1.haifa.il.ibm.com [195.110.40.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8EFAD206F0; Wed, 8 Jan 2020 12:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578488341; bh=Or18NYoRhno1YFa4xw03vLiWPF2Fxp4A3Mm81c8PIao=; h=From:To:Cc:Subject:Date:From; b=O7Zn2gxunIhwEkPj6l2e8WCpsjRpf2yT12TNf6gJ6fPgtQdQk2kD6VsrD13KgV8fZ j9za9lEZKKs3vYyRHXfwYRl4GdLb/DdOXNEkiZTXKX7gaWtaJUxvuQo/7mWvShBqB0 knfrENYT8VdGlFcBeCbc3qVseHSjRFaUo+pVEeLc= From: Mike Rapoport To: "James E.J. Bottomley" Cc: Helge Deller , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , Mike Rapoport , Meelis Roos , Jeroen Roovers , Mikulas Patocka Subject: [PATCH] parisc: fix map_pages() to actually populate upper directory Date: Wed, 8 Jan 2020 14:58:52 +0200 Message-Id: <20200108125852.19823-1-rppt@kernel.org> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Rapoport The commit d96885e277b5 ("parisc: use pgtable-nopXd instead of 4level-fixup") converted PA-RISC to use folded page tables, but it missed the conversion of pgd_populate() to pud_populate() in maps_pages() function. This caused the upper page table directory to remain empty and the system would crash as a result. Using pud_populate() that actually populates the page table instead of dummy pgd_populate() fixes the issue. Fixes: d96885e277b5 ("parisc: use pgtable-nopXd instead of 4level-fixup") Reported-by: Meelis Roos Reported-by: Jeroen Roovers Reported-by: Mikulas Patocka Tested-by: Jeroen Roovers Tested-by: Mikulas Patocka Signed-off-by: Mike Rapoport --- arch/parisc/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c index ddca8287d43b..354cf060b67f 100644 --- a/arch/parisc/mm/init.c +++ b/arch/parisc/mm/init.c @@ -401,7 +401,7 @@ static void __init map_pages(unsigned long start_vaddr, pmd = (pmd_t *) __pa(pmd); } - pgd_populate(NULL, pg_dir, __va(pmd)); + pud_populate(NULL, (pud_t *)pg_dir, __va(pmd)); #endif pg_dir++; -- 2.24.0