From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6913EC282DD for ; Wed, 8 Jan 2020 14:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DAC3206F0 for ; Wed, 8 Jan 2020 14:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578493911; bh=/5qJUAikfHGkQE1xQ11F1gIy/J642JkoxW2N9r35E4Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ive3FmnS9uDWT9qPSmlPDXdvA9nzZPoJzgssPEzlCI3ikDUwZ9W3laLUT+6KATRX5 P9e6S3hocEqhtjWaYmbTlEV0v5fBmetSt9QhEJ0OTI45Ksw8X38DEc7f8Xl5IZSn8r i12n6ZCNEcapWu2tb/k9xcUo7pt8GeGsRhR6Etyc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbgAHObu (ORCPT ); Wed, 8 Jan 2020 09:31:50 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:38064 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbgAHObs (ORCPT ); Wed, 8 Jan 2020 09:31:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cNdj1XMavqHERd1iC1GAYe1krXO6lCtmsBqdFjLoV6M=; b=PbopclKfzaHTWMFWXvcjUw6nY J+aSr1Gq0dnWbRWG/b/BUdLz0FgWrxtH1Ky2Exq9dMwHsD1FihCk1yKNMrHYhS0KAUlMstssxS1S7 bSeO8i98ugtMsFXZ5gyrnEUGecnRfG/RGaJP17soQOqp50h3X60C6m2PXIiqUjAU4exeelCJnJ9ix rjTQKpssdvimmIXCGSS5rV3wDyYZ2Ywgo73XxYp4kTs0kxILBBt99U8RXc2lDNHEFc1OTUEZhpVcO UNMHxDaXlUx3NcOqT2jYUGE7CdeCNl9+ApbyKdu+5OhSvep5nLjyKS9kVIId2oNVHl+PsuytLEtbt wt4BQ5lsA==; Received: from 177.206.132.169.dynamic.adsl.gvt.net.br ([177.206.132.169] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipCN2-0002Z1-Py; Wed, 08 Jan 2020 14:31:41 +0000 Date: Wed, 8 Jan 2020 15:31:26 +0100 From: Mauro Carvalho Chehab To: Jernej Skrabec Cc: mripard@kernel.org, paul.kocialkowski@bootlin.com, hverkuil@xs4all.nl, gregkh@linuxfoundation.org, wens@csie.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] media: uapi: hevc: Add segment address field Message-ID: <20200108153126.49698491@kernel.org> In-Reply-To: <20191213160428.54303-4-jernej.skrabec@siol.net> References: <20191213160428.54303-1-jernej.skrabec@siol.net> <20191213160428.54303-4-jernej.skrabec@siol.net> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, 13 Dec 2019 17:04:27 +0100 Jernej Skrabec escreveu: > If HEVC frame consists of multiple slices, segment address has to be > known in order to properly decode it. > > Add segment address field to slice parameters. > > Signed-off-by: Jernej Skrabec > --- > Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 5 ++++- > include/media/hevc-ctrls.h | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > index aab1451e54d4..5415d5babcc2 100644 > --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst > @@ -3975,6 +3975,9 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - > * - __u32 > - ``data_bit_offset`` > - Offset (in bits) to the video data in the current slice data. > + * - __u32 > + - ``slice_segment_addr`` > + - > * - __u8 > - ``nal_unit_type`` > - > @@ -4052,7 +4055,7 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - > - ``num_rps_poc_lt_curr`` > - The number of reference pictures in the long-term set. > * - __u8 > - - ``padding[7]`` > + - ``padding[5]`` > - Applications and drivers must set this to zero. > * - struct :c:type:`v4l2_hevc_dpb_entry` > - ``dpb[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]`` > diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h > index 1592e52c3614..3e2e32098312 100644 > --- a/include/media/hevc-ctrls.h > +++ b/include/media/hevc-ctrls.h > @@ -167,6 +167,9 @@ struct v4l2_ctrl_hevc_slice_params { > __u32 bit_size; > __u32 data_bit_offset; > > + /* ISO/IEC 23008-2, ITU-T Rec. H.265: General slice segment header */ > + __u32 slice_segment_addr; > + Why are you adding it in the middle of the data? This will break any existing userspace code that might be relying on it. Ok, I know that this header is not yet under include/uapi,and there's a warning on it for letting people know that it shouldn't be used anywhere. Still, people might be using it. > /* ISO/IEC 23008-2, ITU-T Rec. H.265: NAL unit header */ > __u8 nal_unit_type; > __u8 nuh_temporal_id_plus1; > @@ -200,7 +203,7 @@ struct v4l2_ctrl_hevc_slice_params { > __u8 num_rps_poc_st_curr_after; > __u8 num_rps_poc_lt_curr; > > - __u8 padding; > + __u8 padding[5]; > > /* ISO/IEC 23008-2, ITU-T Rec. H.265: General slice segment header */ > struct v4l2_hevc_dpb_entry dpb[V4L2_HEVC_DPB_ENTRIES_NUM_MAX]; Cheers, Mauro