public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Campello <campello@chromium.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Nick Crews <ncrews@chromium.org>,
	Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH] platform/chrome: wilco_ec: Fix keyboard backlight probing
Date: Wed, 8 Jan 2020 08:59:48 -0700	[thread overview]
Message-ID: <20200108155948.GA47901@chromium.org> (raw)
In-Reply-To: <ab377eeb-f1bc-13c2-8bbc-ccc53ecb7c4d@collabora.com>

Hi Enric,

On Wed, Jan 08, 2020 at 11:38:58AM +0100, Enric Balletbo i Serra wrote:
> Hi Daniel,
>
> Many thanks for sending the patch upstream.
>
> On 7/1/20 19:24, Daniel Campello wrote:
> > The EC on the Wilco platform responds with 0xFF to commands related to
> > the keyboard backlight on the absence of a keyboard backlight module.
> > This change allows the EC driver to continue loading even if the
> > backlight module is not present.
> >
>
> Could you explain a bit more which is the problem you're trying to solve? I am
> not sure I understand it, isn't the kbbl_exist call for that purpose? (in
> absence of the keyboard backligh module just don't init the device?)

kbbl_exists is intended to return a bool based on response.status !=
0xFF. Without this patch kbbl_exists will fail and return an -EIO
error on any value of response.status

>
> Thanks,
>  Enric
>

  reply	other threads:[~2020-01-08 15:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 18:24 [PATCH] platform/chrome: wilco_ec: Fix keyboard backlight probing Daniel Campello
2020-01-08 10:38 ` Enric Balletbo i Serra
2020-01-08 15:59   ` Daniel Campello [this message]
2020-01-10 10:46     ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200108155948.GA47901@chromium.org \
    --to=campello@chromium.org \
    --cc=bleung@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncrews@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox