From: Rob Herring <robh@kernel.org>
To: Andreas Klinger <ak@it-klinger.de>
Cc: jic23@kernel.org, mark.rutland@arm.com, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, rpi-receiver@htl-steyr.ac.at,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: devantech-srf04.yaml: add pm feature
Date: Wed, 8 Jan 2020 10:58:13 -0600 [thread overview]
Message-ID: <20200108165813.GA4472@bogus> (raw)
In-Reply-To: <20200102172749.v7ufupd32ytf7jda@arbad>
On Thu, Jan 02, 2020 at 06:27:51PM +0100, Andreas Klinger wrote:
> Add GPIO line and startup time for usage of power management
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> .../bindings/iio/proximity/devantech-srf04.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> index 4e80ea7c1475..b3fcb3b79485 100644
> --- a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> +++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> @@ -51,6 +51,22 @@ properties:
> the time between two interrupts is measured in the driver.
> maxItems: 1
>
> + power-gpios:
> + description:
> + Definition of the GPIO for power management of connected peripheral
> + (output).
> + This GPIO can be used by the external hardware for power management.
> + When the device gets suspended it's switched off and when it resumes
> + it's switched on again. After some period of inactivity the driver
> + get suspended automatically (autosuspend feature).
> + maxItems: 1
> +
> + startup-time-ms:
Why isn't this implied by the compatible string?
> + $ref: /schemas/types.yaml#/definitions/uint32
You can drop this for standard units.
0-2^32 is valid?
> + description:
> + This is the startup time the device needs after a resume to be up and
> + running.
> +
> required:
> - compatible
> - trig-gpios
> --
> 2.11.0
next prev parent reply other threads:[~2020-01-08 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 17:27 [PATCH 1/2] dt-bindings: devantech-srf04.yaml: add pm feature Andreas Klinger
2020-01-08 16:58 ` Rob Herring [this message]
2020-01-09 7:10 ` Andreas Klinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108165813.GA4472@bogus \
--to=robh@kernel.org \
--cc=ak@it-klinger.de \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=rpi-receiver@htl-steyr.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox