From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, TVD_SUBJ_WIPE_DEBT,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A682BC282DD for ; Thu, 9 Jan 2020 13:44:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8372A20661 for ; Thu, 9 Jan 2020 13:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731157AbgAINn7 (ORCPT ); Thu, 9 Jan 2020 08:43:59 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:41206 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725839AbgAINn7 (ORCPT ); Thu, 9 Jan 2020 08:43:59 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: alyssa) with ESMTPSA id E424428DB47 Date: Thu, 9 Jan 2020 08:43:51 -0500 From: Alyssa Rosenzweig To: Steven Price Cc: Daniel Vetter , David Airlie , Rob Herring , Tomeu Vizoso , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Robin Murphy Subject: Re: [PATCH] drm/panfrost: Remove core stack power management Message-ID: <20200109134351.GA3053@kevin> References: <20200109133104.11661-1-steven.price@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <20200109133104.11661-1-steven.price@arm.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable A-b On Thu, Jan 09, 2020 at 01:31:04PM +0000, Steven Price wrote: > Explict management of the GPU's core stacks is only necessary in the > case of a broken integration with the PDC. Since there are no known > platforms which have such a broken integration let's remove the explict > control from the driver since this apparently causes problems on other > platforms and will have a small performance penality. >=20 > The out of tree mali_kbase driver contains this text regarding > controlling the core stack (CONFIGMALI_CORESTACK): >=20 > Enabling this feature on supported GPUs will let the driver powering > on/off the GPU core stack independently without involving the Power > Domain Controller. This should only be enabled on platforms which > integration of the PDC to the Mali GPU is known to be problematic. > This feature is currently only supported on t-Six and t-HEx GPUs. >=20 > If unsure, say N. >=20 > Signed-off-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_gpu.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/pa= nfrost/panfrost_gpu.c > index 8822ec13a0d6..460fc190de6e 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c > @@ -309,10 +309,6 @@ void panfrost_gpu_power_on(struct panfrost_device *p= fdev) > ret =3D readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO, > val, val =3D=3D pfdev->features.l2_present, 100, 1000); > =20 > - gpu_write(pfdev, STACK_PWRON_LO, pfdev->features.stack_present); > - ret |=3D readl_relaxed_poll_timeout(pfdev->iomem + STACK_READY_LO, > - val, val =3D=3D pfdev->features.stack_present, 100, 1000); > - > gpu_write(pfdev, SHADER_PWRON_LO, pfdev->features.shader_present); > ret |=3D readl_relaxed_poll_timeout(pfdev->iomem + SHADER_READY_LO, > val, val =3D=3D pfdev->features.shader_present, 100, 1000); > @@ -329,7 +325,6 @@ void panfrost_gpu_power_off(struct panfrost_device *p= fdev) > { > gpu_write(pfdev, TILER_PWROFF_LO, 0); > gpu_write(pfdev, SHADER_PWROFF_LO, 0); > - gpu_write(pfdev, STACK_PWROFF_LO, 0); > gpu_write(pfdev, L2_PWROFF_LO, 0); > } > =20 > --=20 > 2.20.1 >=20 --jRHKVT23PllUwdXP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEQ17gm7CvANAdqvY4/v5QWgr1WA0FAl4XLgoACgkQ/v5QWgr1 WA3VcA//cEcrQwxrlJ8ndUPseWUHj3sldo778/VRcu6Z6yHCW21o8/xZVa0xQdHX GQuCTw0vDldVAPmxzKhnt41khOHBtYCqeppjYUdC8BQm7IIe+AbN0DoxYR5xRDaB Bo8NcZ7ytOSkzI6Ww91jZVx5jq2k8l5Tj628QbWrDa2t1RP2xzUuet9zWH+9IAyE IjNYszKjYk9MloCyt3AwPSDkHuyKXb9Zc970qHGNAWZC868wIktaQVI6aUl79+uE UeHzGimWKPVPQnIkuQxCS6MaG0sLdcgRjjsTtfIS6TllYLZ/0mWhbE/6smFmmXIb EPfuBVjrK9q4WcXy3DhJHrUnpiDdWm/I7xoy8neKbEb4UHJ0qlsi46NRbYv1fge4 fF0fyWw6VHnti9JRkuqsYWdJ052FEvFEqg3+Dal1oC4HG3Rta+rD72mvmsJtZ1sW JGOXycotJAvQP2U86S7Oml3PcJG9jy4bLvpOk+jU/kTdW12eLhvdouWko/JsCTNI s7x3AvY5Lj7MgNpPt9AKu1GRLHlEPqvG3jVAztc5i1QxaKKhRtYGyb++fBHpBA8B PyrJfcHNckWLgF1kY2cfrIeCZcI9yYSM0Oq2+LpOoTJjFTGbq4te0P5pJR0O0nj3 dAY5fKG3kpp7ObzRhho4ANxt1gpZ41AZvT7NMK6zn98i/xYh0Bw= =nFTn -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP--